Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

call get_a_b on __init__ and store results with Beans object #4

Closed
outs1der opened this issue Dec 8, 2020 · 2 comments
Closed

call get_a_b on __init__ and store results with Beans object #4

outs1der opened this issue Dec 8, 2020 · 2 comments
Assignees

Comments

@outs1der
Copy link
Collaborator

outs1der commented Dec 8, 2020

  • beans version: ?
  • Python version: 3.8
  • Operating System: macOS

Description

generate_burst_train calls get_a_b, which determines the coefficients for the linear flux interpolation, each time it is run. This step needs to be done only once (e.g. when the Beans object is initialised and the flux measurements read in). The a, b coefficients could then be stored as object attributes and passed to the function

@adellej
Copy link
Owner

adellej commented Mar 29, 2021

Duncan I assume this has been fixed now with your pull request? Okay to close this issue?

@outs1der
Copy link
Collaborator Author

outs1der commented Nov 9, 2023

resolved by now allowing more than one choice for the interpolation function, determined upon init with the interp option (allowed values spline and linear, latter the default). Interpolation function is an attribute of the Beans object (along with the coefficients for both the linear and spline versions, so only need to calculate them once)

@outs1der outs1der closed this as completed Nov 9, 2023
@outs1der outs1der self-assigned this Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants