Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BankTransfer: Voiding Payments generated by the process BankTransfer #1555

Closed
SusanneCalderon opened this issue Jan 28, 2018 · 5 comments · Fixed by #1984
Closed

BankTransfer: Voiding Payments generated by the process BankTransfer #1555

SusanneCalderon opened this issue Jan 28, 2018 · 5 comments · Fixed by #1984

Comments

@SusanneCalderon
Copy link
Collaborator

When you want to transfer money from one bank account to another you can do it by using the process BankTransfer, which generates two Payments.
20180128_banktransfer_01

The result is as follows, two payments which is correct.
20180128_banktransfer_02

Usually when you void one payment, you want to void the other, too. Now it has to be done manually and it is easy to be forgotten.
20180128_banktransfer_04

The enhancement is as follows:

  • Similar to the column reversal_ID the corresponding payment is identified by a new column c_Paymentrelated_ID which relates both payments.
  • An additional flag isVoidRelatedPayment in the window Payment decides if the related payment is also voided after voiding a Payment. The default value for this flag is no for backward compatibility.

This enhancement helps to improve the efficiency of the department responsible for payments.

@SusanneCalderon
Copy link
Collaborator Author

After voiding the first payment the related is voided, too.
20180128_banktransfer_05

@e-Evolution
Copy link
Contributor

@SusanneCalderon

When you defined a new columns where the table not exist , you not should use C_PaymentRelated_ID because the ADempiere standard logic will try a table called C_PaymentRelated.

So the good practice is if a column is external link the same table in this case C_Payment then do you should use PaymentRelated_ID because this will be defined as Table and not as TableDir so you not need the prefix C_

marcalwestf added a commit that referenced this issue Jan 31, 2018
BankTransfer
#1555

Remove import to avoid error at build.
marcalwestf added a commit that referenced this issue Jan 31, 2018
@marcalwestf
Copy link
Collaborator

Now the name is defined as the convention.

@yamelsenih
Copy link
Member

I will test it

@yamelsenih yamelsenih added this to the 3.9.1 milestone Jan 31, 2018
e-Evolution pushed a commit to e-Evolution/adempiere that referenced this issue Mar 12, 2018
e-Evolution pushed a commit to e-Evolution/adempiere that referenced this issue Mar 12, 2018
BankTransfer
adempiere#1555

Remove import to avoid error at build.

(cherry picked from commit 747f677)
e-Evolution pushed a commit to e-Evolution/adempiere that referenced this issue Mar 12, 2018
BankTransfer adempiere#1555

Naming conventions.

(cherry picked from commit 602a1d9)
SusanneCalderon added a commit to SusanneCalderon/adempiereSusanne that referenced this issue Mar 13, 2018
…s BankTransfer , Correction of the error in the xml

adempiere#1555
SusanneCalderon added a commit to SusanneCalderon/adempiereSusanne that referenced this issue Mar 13, 2018
@SusanneCalderon
Copy link
Collaborator Author

Rename paymentrelated_ID to relatedPayment_ID, similar a RelatedProduct_ID,
delete isVoidRelatedPayment.
Reason: when the payment is created by a banktransfer, the related payment should always be cancelled .

SusanneCalderon added a commit to SusanneCalderon/adempiereSusanne that referenced this issue Sep 10, 2018
SusanneCalderon added a commit to SusanneCalderon/adempiereSusanne that referenced this issue Oct 3, 2018
SusanneCalderon added a commit to SusanneCalderon/adempiereSusanne that referenced this issue Oct 3, 2018
e-Evolution added a commit that referenced this issue Oct 7, 2018
…e_AndDeleteFlag

#1555 BankTransfer: Voiding PaymentsBankTransfer
fixes
e-Evolution pushed a commit to e-Evolution/adempiere that referenced this issue Oct 7, 2018
e-Evolution pushed a commit to e-Evolution/adempiere that referenced this issue Oct 7, 2018
e-Evolution pushed a commit to e-Evolution/adempiere that referenced this issue Oct 7, 2018
e-Evolution added a commit to e-Evolution/adempiere that referenced this issue Oct 18, 2018
* release/3.9.1: (159 commits)
  adempiere#2074 Bug when try launch a jasper report print format from any Tab adempiere#2074
  adempiere#1722 Enhancement Payroll Send Mail when trying to send the document payroll payment voucher adempiere#1722 - Restore original class and create new SendPayrollReceiptByEmail
  adempiere#1722 Enhancement Payroll Send Mail when trying to send the document payroll payment voucher adempiere#1722
  adempiere#1697, Add improvements for source code, reference to issue: adempiere#1908
  adempiere#1697, Add changes for field definition, reference to issue: adempiere#1697
  adempiere#1975 ZK Process Panel KeyListener remains active when window is no longer visible.  Key listener removed.  OK button setFocus() method used to trap enter key.
  adempiere adempiere#2059 Process Parameters: NPE for reference type Search
  adempiere adempiere#2031 Field LandedCostType in LandedCost
  adempiere adempiere#2031 Field LandedCostType in LandedCost adempiere#2031
  adempiere: adempiere#1918 ReverseAccrual_CostDetForMMatchInv_OR_MMatchPONotFound
  adempiere adempiere#1918 ReverseAccrual_CostDetailForMMatchInv_MMatchPO_Not_Found adempiere#1918
  adempiere: adempiere#1918 ReverseAccrual_CostDetail_MMatchInv_MMatchPO_Not_Found adempiere#1918
  adempiere adempiere#1918 everseAccrual_CostDetailMatchINV/MMatchPO_Not_Found adempiere#1918
  adempiere adempiere#1916 ReverseAccrual generates wrong seqNo in costdetail adempiere#1916
  adempiere#1912 Bug fixes for landedCost and LandedCostAllocation adempiere#1912 from pull request adempiere#1915 from SusanneCalderon/bugfix/Issue1912_LandedCostAllocation_CreateCostDetail
  adempiere adempiere#1555 BankTransfer: Voiding Payments
  adempiere adempiere#1555 BankTransfer: Voiding Payments
  adempiere:  adempiere#1555 BankTransfer: Voiding PaymentsBankTransfer
  adempiere#1676 Enhancement adds a new action to generate a manufacturing order from a project line. adempiere#1676
  Add same change to the new value in case of triggered changes that set the new value before the save.  Improve the comments.
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment