Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes for landedCost and LandedCostAllocation #1912

Closed
SusanneCalderon opened this issue Aug 20, 2018 · 0 comments
Closed

Bug fixes for landedCost and LandedCostAllocation #1912

SusanneCalderon opened this issue Aug 20, 2018 · 0 comments

Comments

@SusanneCalderon
Copy link
Collaborator

Status for working with landed Costs and landedCostAllocation:
Window Purchase Invoice, Line InvoiceLine
Step 1: Generate a Landed Cost entry with the button Generate Landed Cost
Result: depending on the parameter create by product one or several LandedCost entries are generated

Now you can distribute the costs and generated the corresponding landed cost allocation entries with the button distribute Costs. This is preliminary because when the invoice is completed all landed cost allocations will be deleted and generated again.
The process generates also the Costdetail entries for the calculation of the new costs of the corresponding products.

Step 2: Complete the Invoice
All landed cost allocations are deleted and are generated again with the method MInvoiceLine.allocateLandedCosts(). The Costdetails will not be generated and must be generated by using the button Distribute Costs.

Problems

  • In the method MInvoiceLine.allocateLandedCosts() the sequence of the delete statements must be changed. First the costdetails must be deleted, then the landedcost allocations. Otherwise referential integrity is not accomplished.

  • The process Distribute costs should not generate the cost detail entries. As the invoice is not completed the distribution is preliminary. So when the invoice is cancelled or deactivated you have included non-existing costs in your product costs. This problem is evident when you are using costing method average invoice.

In the following screenshot the invoice is cancelled, but the Cost Details are still in the calculation of the new average cost.
invoiceaftercancel

  • When you complete the invoice the cost detail entries are not generated automatically. So until recalculating the product costs manually with the button _distribute costs_the product costs lack the distributed costs of this invoice.
SusanneCalderon added a commit to SusanneCalderon/adempiereSusanne that referenced this issue Aug 20, 2018
…ation

Change delete sequence in MInvoice.allocateLandedCost()
adempiere#1912
SusanneCalderon added a commit to SusanneCalderon/adempiereSusanne that referenced this issue Aug 20, 2018
SusanneCalderon added a commit to SusanneCalderon/adempiereSusanne that referenced this issue Aug 20, 2018
…ation,

LandedCostDistribute should not create cost detail entries
adempiere#1912
SusanneCalderon added a commit to SusanneCalderon/adempiereSusanne that referenced this issue Aug 20, 2018
…ation

Generate cost detail when completing the invoice
adempiere#1912
SusanneCalderon added a commit to SusanneCalderon/adempiereSusanne that referenced this issue Aug 20, 2018
e-Evolution added a commit that referenced this issue Oct 1, 2018
e-Evolution added a commit to e-Evolution/adempiere that referenced this issue Oct 1, 2018
e-Evolution added a commit that referenced this issue Oct 1, 2018
…CostAllocation_DistributeCosts

#1912 Bug fixes for landedCost and LandedCostAllocation
e-Evolution pushed a commit to e-Evolution/adempiere that referenced this issue Oct 2, 2018
…ation,

LandedCostDistribute should not create cost detail entries
adempiere#1912

(cherry picked from commit 73eec4a)
(cherry picked from commit e8c77e8)
e-Evolution pushed a commit to e-Evolution/adempiere that referenced this issue Oct 2, 2018
…ation,

LandedCostDistribute should not create cost detail entries
adempiere#1912

(cherry picked from commit 73eec4a)
e-Evolution added a commit to e-Evolution/adempiere that referenced this issue Oct 2, 2018
* hotfix/3.9.0.a:
  adempiere adempiere#1912 Bug fixes for landedCost and LandedCostAllocation, LandedCostDistribute should not create cost detail entries adempiere#1912
  adempiere#1912 Bug fixes for landedCost and LandedCostAllocation adempiere#1912
e-Evolution added a commit that referenced this issue Oct 7, 2018
…CostAllocation_CreateCostDetail

#1912 Landed cost allocation create cost detail, Create costdetail when completing the invoice
fixes
e-Evolution added a commit to e-Evolution/adempiere that referenced this issue Oct 7, 2018
…piere#1912

from pull request adempiere#1915 from SusanneCalderon/bugfix/Issue1912_LandedCostAllocation_CreateCostDetail
e-Evolution added a commit to e-Evolution/adempiere that referenced this issue Oct 18, 2018
* release/3.9.1: (159 commits)
  adempiere#2074 Bug when try launch a jasper report print format from any Tab adempiere#2074
  adempiere#1722 Enhancement Payroll Send Mail when trying to send the document payroll payment voucher adempiere#1722 - Restore original class and create new SendPayrollReceiptByEmail
  adempiere#1722 Enhancement Payroll Send Mail when trying to send the document payroll payment voucher adempiere#1722
  adempiere#1697, Add improvements for source code, reference to issue: adempiere#1908
  adempiere#1697, Add changes for field definition, reference to issue: adempiere#1697
  adempiere#1975 ZK Process Panel KeyListener remains active when window is no longer visible.  Key listener removed.  OK button setFocus() method used to trap enter key.
  adempiere adempiere#2059 Process Parameters: NPE for reference type Search
  adempiere adempiere#2031 Field LandedCostType in LandedCost
  adempiere adempiere#2031 Field LandedCostType in LandedCost adempiere#2031
  adempiere: adempiere#1918 ReverseAccrual_CostDetForMMatchInv_OR_MMatchPONotFound
  adempiere adempiere#1918 ReverseAccrual_CostDetailForMMatchInv_MMatchPO_Not_Found adempiere#1918
  adempiere: adempiere#1918 ReverseAccrual_CostDetail_MMatchInv_MMatchPO_Not_Found adempiere#1918
  adempiere adempiere#1918 everseAccrual_CostDetailMatchINV/MMatchPO_Not_Found adempiere#1918
  adempiere adempiere#1916 ReverseAccrual generates wrong seqNo in costdetail adempiere#1916
  adempiere#1912 Bug fixes for landedCost and LandedCostAllocation adempiere#1912 from pull request adempiere#1915 from SusanneCalderon/bugfix/Issue1912_LandedCostAllocation_CreateCostDetail
  adempiere adempiere#1555 BankTransfer: Voiding Payments
  adempiere adempiere#1555 BankTransfer: Voiding Payments
  adempiere:  adempiere#1555 BankTransfer: Voiding PaymentsBankTransfer
  adempiere#1676 Enhancement adds a new action to generate a manufacturing order from a project line. adempiere#1676
  Add same change to the new value in case of triggered changes that set the new value before the save.  Improve the comments.
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants