#1697 Add row style change

[yamelsenih]

Hi Guys We have a new feature for add style for rows in ADempiere, please review it.

Issues:

• fixes Add definition for change style #1697
• fixes Add gridfield support for new column AD_FieldDefinition_ID #1710
• fixes Add Need to change the style of the field editors #1709

This project is created for define distinct field style.

The ADempiere field is very static and it does not show distinct behavior when exist important values for end user.

With field style definition a user will can see a field with a distinct Style if a little condition is apporved, example:

We want change color of Document No when delivered quantity is less of ordered quantity

Document No	Quantity Order	Quantity Delivered
🔴#1	10	5
🔵#356	15	15

Here is the E-R Diagram:

[marcalwestf]

Hi @yamelsenih how would the different configuration scenarios look like?
Thanks

[marcalwestf]

Names and sequences don't match:
File 04000_1697_AddColumnFieldDefinition.xml has SeqNo="3790". It should be 4000.
File 04010_1697_AddWindowFieldDefinition.xml has SeqNo="3800". It should be 4010.

[marcalwestf]

...also in 04000_1697_AddColumnFieldDefinition.xml the reference to the issue is missing.

[marcalwestf]

Testing on a seed database up to 03910_1704_FixedAssetBalanceSmartBrowser.xml.

XML 04000_1697_AddColumnFieldDefinition.xml loaded and applied.

XML 04010_1697_AddWindowFieldDefinition.xml loaded, but when applied, the following error message appears:

Haven't found the cause yet, but I suppose -it has happened already in older XMLs- that when defining columns which later are used for window definitions, in the window definition the column is not known because the commit is issued at the end of the XML.

The error here pops up when as a consequence of the unknown reference, the step is rolled back, but fails because is is already referenced.

Will see into it later and report.

[marcalwestf]

... it requires the Quick Entry XMLs....so the earliest XML has to be 03921_1088_Add_Column_IsQuickEntry.xml

[marcalwestf]

The migration of file 04010_1697_AddWindowFieldDefinition.xml works by splitting it in two parts:

• the first part from step 10 to 360, which includes definition of Element and Column
• the second part from step 370 to 1360.

Confirming the previously stated supposition: when defining a column which is later used in the window definition (AD_Window), the XML defining column and field has to be splitted in a column definition section and a field definition section.

[marcalwestf]

After executing the XMLs, a field is displayed in the Application Dictionary, at the "Field" tab of any Window definition:

But it is not possible to zoom it (the zoom icon is dim), because in the table AD_FieldDefinition, there is no window defined for this table. The table has to be configured to be related to the window as the following image depicts:

After correcting the table, the zoom icon is eligible. However, when selecting the zoom icon, an error message is displayed:

.... looking at the role definition for SystemAdministrator, the window Field Definition is not allowed:

Once that done, the window Field Definition is displayed and edited:

[marcalwestf]

... now at last, I can proceed to test...

[marcalwestf]

This is how the window Field Definition looks like:

Observations:

• How does the condition have to look like?
  Is it an SQL? Can the environment syntax be used? etc. etc.
• Same with stylesheets: which can be used?
  A good starter good be to enumerate the possible choices in the help section of the window definition.

[marcalwestf]

..when trying to save a condition, this is the result:

And the error at the console:

===========> MSequence.getNextID: No record found - AD_FieldCondition [18]
===========> MFieldCondition.saveNew: No NextID (-1) [18]
-----------> GridTable.saveWarning: SaveError - [18]

I suppose the sequence was not created.

[marcalwestf]

and a last observation: it would be of great help it there was an example for GardenWorl of how to use it.

[marcalwestf]

here an example of how the configuration goes, kindly provided by Nicolas Lopez ( @niclopup ) : https://www.youtube.com/watch?v=8xS04fCx5Rg&feature=youtu.be

[SusanneCalderon]

Hi @yamelsenih
I have 2 observations:

• The XML 04010_1697_AddWindowFieldDefinition.xml creates en error at seqNO 350. When you move the steps =>350 into a new migrationfile it runs without problems.

• The tables AD_FieldDefinition and AD_FieldCondition have entitytype spinConstribution, which has modelpackage org.spin.model. The classes MFieldCondition and MFieldDefinition are generated in package org.compiere.model, which leads to the error classnotfound.

Correcting these points everything runs without problems.

[SusanneCalderon]

Example: Name of Business Partner is red when open amount > 500

[yamelsenih]

Hi @SusanneCalderon i will change it, thank you for it revision

[yamelsenih]

I will to create a new Pull request for habdle a clear commit

[yamelsenih]

Please see it #2055