-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add GetShouldBeClosed to BaseClient too #57
Comments
Also speaking of closing, there is issue with AFK client and well all of them: they don't detect disconnect very well, sometimes it just stays active and "connected" when in reality it is already not. Maybe a timeout by ping packets or at least method like "GetLastPingTime" to detect that client dropped connection |
There will be some modifications of all XXXClients with the new behaviour system (arriving soon-ish maybe perhaps I hope). I'll try to move the should_be_closed bool to a higher level in the hierarchy. Concerning your second point, could you elaborate on how to reproduce this kind of disconnection? When the server kicks the player or when the connection is lost? |
I believe server just drops connection silently and does not even close socket. I experienced such "drops" on regular and hacked clients and both of them timeout after 30 seconds of last ping/tick from server, most likely considering socket dead. |
Fixed with the new Client organization |
Why it is present only on interface client?
The text was updated successfully, but these errors were encountered: