Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documenting vendor- and country-specific fields #312

Open
arjanlamersmanuchar opened this issue Aug 22, 2022 · 3 comments
Open

Documenting vendor- and country-specific fields #312

arjanlamersmanuchar opened this issue Aug 22, 2022 · 3 comments
Assignees
Labels
next-minor-release The issue is not scheduled for the current release, but planned for a release soon after that. question Further information is requested

Comments

@arjanlamersmanuchar
Copy link

At JoinData we got the request to publish country-specific fields in our documentation. Since our documentation is based on ICAR published standards, this is something that we are hesitant to do. Especially since we may have multiple sources and we would have to merge individual extensions to a single document. If a client connects directly to a service, this is not a problem: the service simply will publish its own extended version of ADE. But for a hub like JoinData, it is more tricky.

Context

ICAR ADE currently states You are free to simply add more fields to your messages than described in the standard., which is makes perfect sense.

It also states that:
"Consider if your field is potentially standardizable. If other regions or vendors may require something similar, define it in such a way that it may become part of the standard at one time."

This is currently a bit tricky: there is no way to see what other vendors or countries are doing and if you are potentially creating conflicting, ambiguous or duplicate fields.

Proposal
A proposal to solve this is to have ICAR publish known vendor- or country specific fields. That could be done by publishing e.g. an arrivals-with-extended-fields message next to the arrivals message (extending it). Vendors are then able to publish their specific fields at that message, solving any conflicts there, while at the same time keeping the standard concise. This would also allow a field to be promoted to the standard when the WG decides on that (as is hinted on the wiki as well: " By doing this, no technical changes may be required by the time a new version comes out which includes this field.").

@alamers
Copy link
Collaborator

alamers commented Aug 22, 2022

Oops, published it on a different account ;)

@alamers alamers added agenda-next-meeting question Further information is requested labels Aug 22, 2022
@cookeac
Copy link
Collaborator

cookeac commented Aug 25, 2022

At our meeting on 2022-08-25 we agreed that these parallel extended resources would be a good method of documentation:

  • They should be placed in a separate folder (e.g. /extended-fields or /proposed-extensions)
  • They should use "allOf" to incorporate the standard resources
  • They are only for documentation purposes - not part of the standard or incorporated in the example URL schemes
  • Implementers may choose to replace the standard resources with these within their own implementations if they want to support all possible extensions.
  • Proposers will still submit pull requests which the technical working group can review, which will help us suggest where these could usefully be incorporated in a future version of the standard.

@alamers and @erwinspeybroeck will test this in a use case they are working on and the technical working group will review.

@cookeac cookeac added the next-minor-release The issue is not scheduled for the current release, but planned for a release soon after that. label Oct 6, 2022
@cookeac
Copy link
Collaborator

cookeac commented Nov 17, 2022

The current pressure for this has lessened. If anyone else needs this, they could pick up this issue and implement as suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next-minor-release The issue is not scheduled for the current release, but planned for a release soon after that. question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants