Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Samsung browser is now available on non-samsung devices #56

Closed
ameshkov opened this issue Mar 6, 2017 · 10 comments
Closed

Samsung browser is now available on non-samsung devices #56

ameshkov opened this issue Mar 6, 2017 · 10 comments
Assignees
@nkartyshov
Milestone
1.5

Comments

@ameshkov
Copy link
Member

ameshkov commented Mar 6, 2017

So we should allow people to choose & install it.
@Alex-302
Copy link
Member

Alex-302 commented Mar 6, 2017

Google Play says it is not supported on my device(Sony Xperia Z1c), but Samsung browser is available in AG

image

@ameshkov
Copy link
Member Author

ameshkov commented Mar 6, 2017

Beta version is available:
https://play.google.com/store/apps/details?id=com.sec.android.app.sbrowser.beta

@ameshkov
Copy link
Member Author

ameshkov commented Mar 6, 2017

Ah, sorry, it seems that i am wrong

@theseanl
Copy link
Contributor

theseanl commented Mar 6, 2017 •
edited
Loading

It is not currently available in all country. It is not available in US.

@theseanl
Copy link
Contributor

Now the app is available in other countries too.
The apk can be downloaded at: http://www.apkmirror.com/apk/samsung-electronics-co-ltd/samsung-internet-beta/samsung-internet-beta-5-4-00-3-release/samsung-internet-beta-5-4-00-3-android-apk-download/

@nkartyshov nkartyshov self-assigned this Mar 23, 2017
nkartyshov added a commit that referenced this issue Mar 23, 2017
@nkartyshov
https://github.com/AdguardTeam/ContentBlocker/issues/56
54f5d41 
 fixed opening samsung browser beta
@ameshkov ameshkov added this to the 1.5 milestone Mar 26, 2017
nkartyshov added a commit that referenced this issue Mar 28, 2017
@nkartyshov
https://github.com/AdguardTeam/ContentBlocker/issues/56
b66f5f0 
 added lint to issue
@nkartyshov
Copy link
Contributor

Fixed

@theseanl
Copy link
Contributor

theseanl commented May 1, 2017

Now, it only shows Samsung browser beta and does not show Samsung browser in the main page. So I can't access settings page of Samsung browser from the Adguard main screen.
Their package names are different: com.sec.android.app.sbrowser and com.sec.android.app.sbrowser.beta

@theseanl theseanl reopened this May 1, 2017
@ameshkov
Copy link
Member Author

ameshkov commented May 1, 2017

Now, it only shows Samsung browser beta and does not show Samsung browser in the main page.

As I recall, we have one block for Samsung, it will correspond to either beta or release browser (beta has higher priority).

@theseanl
Copy link
Contributor

theseanl commented May 1, 2017 •
edited
Loading

So is it not an issue? Users may have both browsers installed in the device and cannot access the configuration page directly from Adguard app.

@ameshkov
Copy link
Member Author

ameshkov commented May 1, 2017

So is it not an issue?

It might be an issue, but it's not a bug. File a change request plz.

@ameshkov ameshkov closed this as completed May 1, 2017
adguard pushed a commit that referenced this issue Sep 30, 2019
@artemiv4nov
Merge pull request #56 in ANDROID/content-blocker from hotfix to master
10bdbc2 
* commit 'f7f5207b56e91255a31e63c2021ad2f1967105ad':
  Updated translates
  Added comments
  Added copyright header to files
  Improved filters update
  Refactored code
  updated version
  Added WorkManager to schedule jobs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nkartyshov nkartyshov

Labels
None yet
Projects
None yet
Milestone
1.5
Development

No branches or pull requests
4 participants
@nkartyshov @ameshkov @Alex-302 @theseanl