Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

False-positive on disqus.com/embed/ #53

Closed
theseanl opened this issue Oct 31, 2017 · 1 comment
Closed

False-positive on disqus.com/embed/ #53

theseanl opened this issue Oct 31, 2017 · 1 comment
Assignees
@theseanl
Labels
bug

Comments

@theseanl
Copy link
Contributor

theseanl commented Oct 31, 2017 •
edited

Steps to reproduce:

Result:
An error is displayed in the devtools console.

We need to wrap every place where we access Function.arguments with try-catch block. Also, we need to include disqus iframe into default exceptions in release versions.
@theseanl theseanl self-assigned this Oct 31, 2017
@theseanl theseanl added the bug label Oct 31, 2017
@theseanl
Copy link
Contributor Author

Fixed in 528cdab.

northis added a commit that referenced this issue Oct 4, 2018
@northis
Merge pull request #53 in EXTENSIONS/popup-blocker from fix/142 to ma…
8d96912 
…ster

Squashed commit of the following:

commit 01bb7c24c887f361c8dd88fde56d42466f164a58
Author: Mikhail Berdnikov <m.berdnikov@adguard.com>
Date:   Fri Aug 31 17:26:22 2018 +0300

    Issue#141 & 142, relative pathes & excludes in beta
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@theseanl theseanl

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@theseanl