Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redirecting to terminate Playback on Asterisk 13 causes exceptions #593

Open
benlangfeld opened this issue Dec 7, 2015 · 4 comments
Open

Redirecting to terminate Playback on Asterisk 13 causes exceptions #593

benlangfeld opened this issue Dec 7, 2015 · 4 comments
Labels
asterisk-12-compatibility
Milestone
3.1.0

Comments

@benlangfeld
Copy link
Member

See adhearsion/adhearsion-asr#29 (comment)

We must switch to ControlPlayback at least when we use Playback. We should investigate what happens with UniMRCP apps.
@benlangfeld benlangfeld mentioned this issue Dec 7, 2015
Closed
@benlangfeld benlangfeld added this to the 3.0.0 milestone Dec 7, 2015
@benlangfeld
Copy link
Member Author

See adhearsion/ruby_ami#34 for exposing the AMI version. We can use ControlPlayback when the AMI version is >= 2.0.0.

benlangfeld added a commit that referenced this issue Dec 7, 2015
@benlangfeld
Scratch pad
c893ee8 
See #593
@benlangfeld
Copy link
Member Author

The above commit needs tests and wiring in to the AMI version exposed by RubyAMI::Stream#version. Anyone who can pick this up would be most appreciated.

neildecapia added a commit to neildecapia/adhearsion that referenced this issue Dec 31, 2015
@neildecapia
Stopping playback via ControlPlayback on newer Asterisk versions
2057f59 
Use `ControlPlayback` rather than redirecting to terminate `Playback` on
newer versions of Asterisk. Since this can be expected to be the
preferred practice going forward, the makeshift `StopByRedirect`
mechanism (component) has been changed to the more appropriate (if
generic) `StopPlayback`.

Addresses adhearsion#593 Redirecting to terminate Playback on Asterisk 13 causes
exceptions
@neildecapia neildecapia mentioned this issue Dec 31, 2015
Open
neildecapia added a commit to neildecapia/adhearsion that referenced this issue Jan 4, 2016
@neildecapia
Stopping output via ControlPlayback on newer Asterisk versions
be77ccb 
Use `ControlPlayback` rather than redirecting to terminate output
`Playback` on newer versions of Asterisk.

Addresses adhearsion#593 Redirecting to terminate Playback on Asterisk 13 causes
exceptions
@benlangfeld benlangfeld modified the milestones: 3.0.0, 3.1.0 Jan 5, 2016
@neildecapia
Copy link
Member

It looks like we can't use ControlPlayback because it only controls the currently-playing file. If Playback is given multiple files then ControlPlayback won't be able to break out of it (unless it's already playing the last one).

And the Redirect mechanism breaks when used in Asterisk 13 because Playback returns a PLAYBACKSTATUS of "FAILED" when in Asterisk 11 it reported "SUCCESS".

Opened an issue in Asterisk: https://issues.asterisk.org/jira/browse/ASTERISK-25661.

@meghasharma92
Copy link

Facing the same issue in Asterisk 13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
asterisk-12-compatibility
Projects
None yet
Milestone
3.1.0
Development

No branches or pull requests
3 participants
@neildecapia @benlangfeld @meghasharma92