cleanup CI (and some specs) #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, thank you! Will wait for CI and review. |
|
great, should have not added that events spec here, its relevant but fixing it is a separate topic. |
... we're also doing proper (non-GIL) concurrency
benlangfeld
approved these changes
Jan 29, 2019
it is expected to have fixed a mutex bug
sfgeorge
approved these changes
Jul 8, 2019
There was a problem hiding this comment.
This looks great, thank you @kares 👍 Sorry for the delay in reviewing.
During the code review delay a new release of nio4r (2.4.0) has come out, which unfortunately broke the build for all JRuby flavors, because nio4r-2.4.0 currently lacks a -java package.
Let's merge this PR, and deal with the nio4r issue separately in #637
|
New plan - since the build failure blocks this from being merged. We'll just merge #637 instead and close this PR. |
|
cool, thanks for handling this ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as there's likely to come some more changes later, start of with a ~ 💚 CI
can split commits into separate PRs if required
previous attempt should be obsolete, closes #607