Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

send pictures of bikes? #5

Closed
adherr opened this issue May 19, 2014 · 2 comments
Closed

send pictures of bikes? #5

adherr opened this issue May 19, 2014 · 2 comments
Assignees
@adherr
Labels
enhancement

Comments

@adherr
Copy link
Owner

adherr commented May 19, 2014

Is this a good idea at all? only for stolen bikes? only for bikes that have non-stock photos?
@adherr adherr self-assigned this May 19, 2014
@adherr adherr changed the title send pictures of bikes send pictures of bikes? May 19, 2014
@sethherr
Copy link
Collaborator

I think you should always send pictures if you can. Pictures are cool.

I'm going to make the Index respond without the photos or components if it's a search (only respond with everything when you query a specific bike) and I'll include the photo if there is a photo or a stock photo in the response.

@adherr
Copy link
Owner Author

adherr commented May 20, 2014

Whatever photo is returned in "photo" is getting sent. It's pretty sweet.

@adherr adherr closed this as completed May 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adherr adherr

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sethherr @adherr