Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make it a Class #6

Closed
adherr opened this issue May 19, 2014 · 2 comments
Closed

make it a Class #6

adherr opened this issue May 19, 2014 · 2 comments

Comments

@adherr
Copy link
Owner

adherr commented May 19, 2014

No description provided.

@adherr adherr self-assigned this May 19, 2014
@adherr
Copy link
Owner Author

adherr commented May 20, 2014

Done? Requesting comments, I'll close this in a week.

@sethherr
Copy link
Collaborator

Ok, this looks much better. Some methods are still large, I think this would be improved if you break some of them up - in particular initialize and process_tweet.

I also don't like giant initialize functions. Consider requiring a file that loads dotenv and sets the tweetstream configuration separately.

And remove is_it_stolen.rb from the repo if it isn't used!

@adherr adherr closed this as completed May 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants