Fix Typo From liablity To liability #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 5, 2023
|
There might be other changes that need to be made. |
6 tasks
Re: mdTranslatorAPI URL Remove outdated URL. Uncomment production URL.
New function definition to handle the more generic use case from a different location. This should handle all import formats.
hmaier-fws
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes Issues
closes #497
adiwg/mdEditor/issues/497
Changes:
import:
Currently, when the user selects a file to import, the process will determine the type of file import then use the respective process to pre-load data from that type of source before sending it to the UI. Fixing the liability typo happens immediately before returning the data to the UI. At this point nothing has been imported into the store, it is pre-loaded into the UI for the user to view before saving the imported data. To summarize, the liability typo is fixed before the data to be imported is displayed in the UI.
export:
Currently, the data from the store is dumped into a file. The new change here is the 'export all' button will fix the liability typo in the store before exporting. This will fix existing records so the simple act of exporting will fix existing typos. The subsequently exported data will be fixed, but so will the data stored in the local environment, fixing existing records.
Test deployment updated 8/28/2023: http://34.201.136.147:8001/