-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Liability Statement Missing in Translations from mdJSON #236
Comments
I think the issue might be, related to this comment in the fgdc writer for distribution
so if they're no distributor, no distribution info gets printed out. I added a check if there's no distributors, still print out the description and liabilityStatement |
While that rule is true, it is not the use case here in which there is a single distribution. Here is the mdJSON, followed by the translated CSDGM:
The distliab tags should appear below the resdesc tags |
@dwalt I see the issue, it looks like there a misspelling, this is coming from mdEditor https://github.com/adiwg/mdEditor/blob/f94770686df07ef76aa111f8f9734b32bbad7f21/app/pods/components/object/md-distribution/template.hbs#L22 since this is in the Production version I'll do a little digging on how we can handle upgrading existing mdJson to the correct spelling transparently in the editor, and I suppose we should handle both spellings in the translator |
Good eye! I would agree with supporting both spellings in the translator to avoid breaking older mdJSON files. I am surprised the schema validator did not catch the invalid tag. |
@dwalt this and the other "CSDGM" issues are deployed here for testing: https://dev-translator.mdeditor.org/demo (and https://dev-editor.mdeditor.org/dashboard points to the above) |
mdJSON-CSDGM translated successfully in test |
@dwalt how do we want to handle instances where BOTH a liabilityStatement (imported from CSDGM) and a liablityStatement (missing i) are present? I came across an instance of this today. In theory, the statement entered via the editor (after CSDGM import) could supersede the initial statement. Do we want to append the two values into a single statement? |
@hmaier-fws I would tend to think that what the user entered in mdEditor is the latest and greatest and should supersede what was imported. Often, the re-entered text is the same as what was imported, so if it is appended, it is definitely wrong. |
This problem has been discovered in -2 output and HTML and is therefore universal. The fix should solve it for all writers that write Liability Statement, but should be verified. |
PR created adiwg/mdEditor#557 |
adiwg/mdEditor#497 is related |
Distribution Liability (distliab) is not writing to CSDGM from mdJSON input: schema{ } > metadata{ } > resourceDistribution[ ] > distribution{ } > liabilityStatement. Data appears to be in mdJSON file.
The text was updated successfully, but these errors were encountered: