Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Seismic Unix (SU) format support and bugfix default preprocessing #174

Open
5 tasks
bch0w opened this issue Jul 20, 2023 · 1 comment
Open
5 tasks

Comments

@bch0w
Copy link
Member

bch0w commented Jul 20, 2023

Based on discussion raised by @Ben-J-Eppinger in #173, the original version of SeisFlows provided support for the Seismic Unix (SU) format and provided useful preprocessing functions related to exploration-scale seismic problems, such as arrival muting, normalization etc.

In the course of the re-write, these capabilities were brought over but not tested extensively or at all, leading to a broken implementation of these features. Many of the functions and logic loops still exist but will need some bugfixing to get working again.

Tasks for this PR include:

  • Preprocess.read() can read/write SU format traces
  • Preprocess.write() can write SU format adjoint sources
  • Ensure SPECFEM2D/3D/3D_GLOBE implementations of SU format are accounted for
  • Fix and test function preprocess.default._apply_mute()
  • Complete Event-based normalization portion of preprocess.default._apply_normalize()
@bch0w bch0w changed the title Add Seismic Unix (SU) format support and bugfix default preprocessing Fix Seismic Unix (SU) format support and bugfix default preprocessing Jul 20, 2023
@aakash10gupta
Copy link
Member

I think I encountered a bug in the default preprocessing module. When I set the flag components: 'Z' in the parameters.yaml file, even then all the components get used for computing adjoint sources and the subsequent analysis instead of just the Z component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants