Question: retrieve_statement.py's findstmtrefs function, why?

[MonkoftheFunk]

Hi, First off Thank you for building this, it has really been helpful, you guys did a lot of work.

So if the complex query already finds all the statements that match, wouldn't searching (and recursively searching) through statement refs. come up with same results? Thanks for the insight

# only find references when a filter other than
# since, until, or limit was used 
    if reffilter:
        stmtset = findstmtrefs(stmtset.distinct(), sinceq, untilq)

[creighton]

Your comments are welcome. Especially with the statement retrieval code, which we are constantly trying to optimize.

If I remember correctly that block of code is trying to meet the search requirements in the spec (https://github.com/adlnet/xAPI-Spec/blob/master/xAPI.md#filter-conditions-for-statementrefs) where it says the search criteria matches statements, and statements that reference matching statements.

So for example (and one of the statements I've used for testing), take statements: "tom hacked a computer" and "IT stopped [tom hacked a computer]". If I search for statements with tom as the actor, I should get both of those statements.

[MonkoftheFunk]

Gotcha, that makes sense, should have read that part of the spec closer
Thanks again, again great work