Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect derivative computation in function mfexp for values greater than 60 #113

Closed
johnoel opened this issue Aug 10, 2019 · 1 comment

Comments

@johnoel
Copy link
Contributor

johnoel commented Aug 10, 2019

In linad99/fvar_a50.cpp line 34, the computed mfexp values for x > 60 is

vtmp.elem_value(i)=exp(60.)*(1.+2.*x)/(1.+x);

and the incorrect computed derivative value is

dfv1(i)=dfvtmp(i)*exp(60.0)*(1./(1.+b*b));

from line 74 in adjoint function DF_dvmfexp.

The computed derivative should be

dfv1(i)=dfvtmp(i)*exp(60.0)*(1./((1.+b)*(1.+b)));
johnoel added a commit that referenced this issue Aug 11, 2019
@johnoel
Copy link
Contributor Author

johnoel commented Aug 12, 2019

Dave confirmed it is okay. Merged ac4072b

@johnoel johnoel closed this as completed Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant