Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to stream command output #438

Closed
milolav opened this issue Jul 14, 2020 · 1 comment
Closed

Ability to stream command output #438

milolav opened this issue Jul 14, 2020 · 1 comment

Comments

@milolav
Copy link

milolav commented Jul 14, 2020

I've added ability to stream command output directly to a response. milolav@09642fb

Needed it to monitor manually invoked long running scripts. It is based on a code mentioned in this question https://stackoverflow.com/questions/19292113/not-buffered-http-responsewritter-in-golang

If script starts, a response will always be successful regardless of the exit code.

Would this addition be something in line with project goals?

One issue that I've noticed is when opening hook url in a browser, response gets delayed for a few seconds and I have no idea why. When opening with curl/wget response starts streaming immediately. Implementation from the stackoverflow ( https://play.golang.org/p/PpbPyXbtEs ) doesn't have this issue.

@moorereason
Copy link
Collaborator

Thanks for reaching out. We already have an existing issue discussing this feature (#250), so I'm going to close this issue as a duplicate. Further discussion of the feature can happen on #250. You can compare your branch to #251. If you want comments on your implementation, create a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants