Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smiley instead of a bold result #50

Closed
GoogleCodeExporter opened this issue Mar 21, 2015 · 13 comments
Closed

Smiley instead of a bold result #50

GoogleCodeExporter opened this issue Mar 21, 2015 · 13 comments

Comments

@GoogleCodeExporter
Copy link

What steps will reproduce the problem?
1. Enable "Format result" option
2. receive a bold result with a ":" character at the end.
3.

What is the expected output? What do you see instead?
The expected output is a result in bold. Instead I see the smiley :* on gatlk.

What version of the product are you using? On what operating system?
v1.7.1 on HTC Desire Android 2.2

Please provide any additional information below.
This issue can be corrected by using a non-breaking space (U+00A0) between the 
":" and the "*".

Original issue reported on code.google.com by g.caba...@gmail.com on 15 Jan 2011 at 10:55

@GoogleCodeExporter
Copy link
Author

Just tested the makeBold() and makeItalic() methods with e.g.:
return " *\u00a0" + in + "\u00a0* ";
But at least my jabber client (gajim) show then no bold or italic text.

Original comment by fschm...@gmail.com on 20 Jan 2011 at 5:48

@GoogleCodeExporter
Copy link
Author

Original comment by Florent....@gmail.com on 22 Jan 2011 at 6:28

  • Changed state: WaitingForRelease

@GoogleCodeExporter
Copy link
Author

Fixed in 1.7.3

Original comment by Florent....@gmail.com on 22 Jan 2011 at 8:07

  • Changed state: Fixed

@GoogleCodeExporter
Copy link
Author

FYI: Some jabber clients wont show the bold/italic text if there is a 
whitespace before/after the */?. I could reproduce this behavior, with 2 of my 
clients: gajim and psi.

Original comment by fschm...@gmail.com on 23 Jan 2011 at 10:57

@GoogleCodeExporter
Copy link
Author

I've just added a leading space for the ending star " * ". Do you have the bug 
with the 1.7.3 with the help command for example ?

Original comment by Florent....@gmail.com on 23 Jan 2011 at 11:23

@GoogleCodeExporter
Copy link
Author

Yes, this was with 1.7.3 and the help command. The leading space breaks the 
bold for me.

Original comment by fschm...@gmail.com on 23 Jan 2011 at 11:29

@GoogleCodeExporter
Copy link
Author

Original comment by Florent....@gmail.com on 23 Jan 2011 at 11:51

  • Changed state: New

@GoogleCodeExporter
Copy link
Author

finally won't fix.
We now use XHTML formatting.
If your xmpp client doesn't support XHTML, it will show old formatting.
But old formatting by using * or _ is more a trick than a real feature because 
all xmpp clients manage that in different ways...

Original comment by Florent....@gmail.com on 2 Feb 2011 at 9:06

  • Changed state: WontFix

@GoogleCodeExporter
Copy link
Author

Issue 86 has been merged into this issue.

Original comment by fschm...@gmail.com on 8 Feb 2011 at 2:17

@GoogleCodeExporter
Copy link
Author

There are many clients which do not support xhtml messages. This goes for the 
two I tested: Psi and Miranda.
However, a way better way, even as workaround, is using BBcode. I now use 
gTalkSMS like this and am happy with it.



XmppMsg.java:108

public String generateFmtTxt() {
    return _message.toString()
        .replaceAll(FontBegin, "")
        .replaceAll(BoldBegin, " [b]")
        .replaceAll(BoldEnd, "[/b] ")
        .replaceAll(ItalicBegin, " [u]")
        .replaceAll(ItalicEnd, "[/u] ");
}

Original comment by ThDietri...@gmail.com on 10 Feb 2011 at 2:10

@GoogleCodeExporter
Copy link
Author

BBCode appears to be specific to the MSN protocol, and pidgin doesn't support 
it.  Does the gtalk UI support it?  If not, I'd have to recommend we do not go 
this route.

Original comment by skippy.hammond@gmail.com on 10 Feb 2011 at 11:47

@GoogleCodeExporter
Copy link
Author

Both formating styles have it's disadvantages. Only the user can decide which 
fits best. Making this an option is at as easy as an if else block.
I am in favour of an additional option, as it turns out that there are XMPP 
clients out there, that dont proper support xhtml. But first we have to 
reorganised the settings.

Original comment by fschm...@gmail.com on 11 Feb 2011 at 7:22

@GoogleCodeExporter
Copy link
Author

Agreed, an option to select the preferred non-xhtml formatting would be perfect.

Original comment by ThDietri...@gmail.com on 11 Feb 2011 at 11:57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant