Fix startup on existing data folder issues #1245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure where this bit of code came from, but if a bucket was named "test", S3Mock would have ignored its existence when starting... Fixes #1224
Not sure this can ever happen, but if S3Mock is loading a bucket, we should not allow concurrent modifications on it. Fixes #1224
This makes it easier to see if there were errors, and if the correct # of objects were loaded when starting S3Mock on an existing data folder. Fixes #1224
The data folder should only be used by S3Mock, so this should not happen. Still, guard against the possibility that somehow, folders without a "bucketMetadata.json" (=folders that are not a bucket) are present in the data folder and skip them while loading buckets on startup. Fixes #1224
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Fixes #1224
Tasks