More Specific Response Content Type #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution, let me take a look. |
timoe
suggested changes
Nov 29, 2019
server/src/test/java/com/adobe/testing/s3mock/its/PlainHttpIT.java
Outdated
Show resolved
Hide resolved
server/src/test/java/com/adobe/testing/s3mock/its/PlainHttpIT.java
Outdated
Show resolved
Hide resolved
|
hey guys, any update on this? I can't really tell why the build is failing on travis, probably missing something. |
|
@DanieleSassoli Build is failing due to check-style violation https://travis-ci.org/adobe/S3Mock/builds/619544525#L575 |
|
Thanks for the hint @DanieleSassoli @ChaithanyaGK . I missed to follow up here. Just pushed the checkstyle changes incl. merge from upstream master |
…esponse content type to be more consistent with http and aws spec
timoe
approved these changes
Dec 28, 2019
|
I'll do a release on Monday |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some of the S3Mock endoints return a
application/x-www-form-urlencodedContent-Type, which is ignored by most clients but is HTTP specification wise not correct. The AWS API spec doesn't explicitly describe the Content-Type, but the the actual response body is XML and the Content-Typeapplication/octet-streamSome strict clients (e.g. Akka HTTP, Alpakka), correctly reject parsing a Content-Type of
application/x-www-form-urlencodedas XML, but rather expectapplication/octet-streamorapplication/xml.I've tried changing the Content-Type to
application/octet-stream, but the Spring Framework always returns a400 - Bad Requestthen in the IT tests. I couldn't figure out why, but my guess is that it doesn't know that this response should be marshalled XML. Changing the Content-Type to returnapplication/xmlworks on the other hand. Both, the IT tests and the Akka HTTP client are happy then. I know that's not ideal as it's not an accurate implementation of the S3 API, but I'd argue it is still more correct than the current implementation.Related Issue
#35
Tasks