Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIF-2946: add cif specific composite status type for editor to classic #308

Merged
merged 2 commits into from
Sep 1, 2022

Conversation

Buuhuu
Copy link
Contributor

@Buuhuu Buuhuu commented Aug 30, 2022

Description

Added the Composite Status Type for editor that was moved to the CS quickstart to Venia for classic.

Related Issue

adobe/aem-core-cif-components#951
#264

Motivation and Context

How Has This Been Tested?

Locally, the configuration has a higher priority of the ootb one from /libs

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Merging #308 (928f8ee) into dev (3305a19) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                dev     #308   +/-   ##
=========================================
  Coverage     77.14%   77.14%           
  Complexity       21       21           
=========================================
  Files             1        1           
  Lines            35       35           
  Branches          4        4           
=========================================
  Hits             27       27           
  Misses            6        6           
  Partials          2        2           
Flag Coverage Δ
unittests 77.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@LSantha LSantha merged commit 81d8025 into dev Sep 1, 2022
@LSantha LSantha deleted the issue/CIF-2946 branch September 1, 2022 09:40
@LSantha LSantha added the bug Something isn't working label Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants