Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIF-2946: add editor composite status type for cif #980

Merged
merged 1 commit into from Sep 7, 2022

Conversation

Buuhuu
Copy link
Contributor

@Buuhuu Buuhuu commented Sep 2, 2022

Description

This adds an overwrite of the editor composite status type for CIF 6.5 projects, adding the catalog-page status provider.

The configuration is only added with includeCommerce='y' and aemVersion not being cloud.

Related Issue

CIF-2946
adobe/aem-core-cif-components#849
adobe/aem-cif-guides-venia#308

Motivation and Context

Show the status when the author edits a CIF template page to warn them about the impact this may have.

How Has This Been Tested?

manually using mvn clean install and inspecting the generated test-cases.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@LSantha LSantha added enhancement New feature, or improvement to an existing feature. verified labels Sep 7, 2022
@LSantha LSantha merged commit a9de047 into develop Sep 7, 2022
@LSantha LSantha deleted the issue/CIF-2946 branch September 7, 2022 07:04
@vladbailescu vladbailescu added this to the 39 milestone Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, or improvement to an existing feature. verified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants