Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Product and Category redirect servlets not registered for v3 page resource type #987

Closed
buuhuu opened this issue Sep 7, 2023 · 1 comment
Closed

Product and Category redirect servlets not registered for v3 page resource type #987

buuhuu opened this issue Sep 7, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@buuhuu
Copy link
Contributor

buuhuu commented Sep 7, 2023 •
edited
Loading

As the title say, the servlets used to redirect to a product page or category page from a given identifier (sku/url-key) are only registered for the resoruce types of page v1 and v2, not v3.

The redirect seems not to work anymore with aem-cif-guides-venia.

See https://publish-p10603-e192905-cmstg.adobeaemcloud.com/content/venia/us/en.cifproductredirect.html/MP05 for example. This should redirect to the product page url.

https://github.com/adobe/aem-core-cif-components/blob/master/bundles/core/src/main/java/com/adobe/cq/commerce/core/components/internal/servlets/ProductPageRedirectServlet.java#L39-L47
@buuhuu buuhuu added the bug Something isn't working label Sep 8, 2023
@buuhuu
Copy link
Contributor Author

buuhuu commented Oct 18, 2023

That also includes the CatalogPageNotFoundFilder.

@buuhuu buuhuu mentioned this issue Oct 18, 2023
Merged
10 tasks
@LSantha LSantha added verified and removed verified labels Dec 8, 2023
LSantha added a commit that referenced this issue Dec 8, 2023
@buuhuu @LSantha
#987 - Product and Category redirect servlets not registered for v3 p…
56b8e37 
…age resource type (#989)

* fix: add Page v3 resource type to CatalogPageNotFoundFilter
* fix: add Page v3 resource type to ProductPageRedirectServlet
* fix: add Page v3 resource type to CategoryPageRedirectServlet

---------

Co-authored-by: Levente Sántha <levente@adobe.com>
@LSantha LSantha closed this as completed Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@buuhuu @LSantha