Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add Page v3 resource type to CatalogPageNotFoundFilter and redirect servlets #989

Merged
merged 4 commits into from
Dec 8, 2023

Conversation

buuhuu
Copy link
Contributor

@buuhuu buuhuu commented Oct 18, 2023

Description

Some of the servlets and filters are not yet registered for the Page v3 resource type. The functionality provided by them is missing.

Related Issue

#987

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

@buuhuu buuhuu changed the title fix: add Page v3 resource type to CatalogPageNotFoundFilter fix: add Page v3 resource type to CatalogPageNotFoundFilter and redirect servlets Oct 18, 2023
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (77d2b0b) 89.12% compared to head (fdd0742) 89.12%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #989   +/-   ##
=========================================
  Coverage     89.12%   89.12%           
  Complexity     2215     2215           
=========================================
  Files           354      354           
  Lines          9999     9999           
  Branches       1440     1440           
=========================================
  Hits           8912     8912           
  Misses          789      789           
  Partials        298      298           
Flag Coverage Δ
integration 51.81% <ø> (ø)
jest 86.68% <ø> (ø)
karma 95.53% <ø> (ø)
unittests 87.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@herzog31 herzog31 requested a review from LSantha October 30, 2023 08:53
@LSantha LSantha marked this pull request as ready for review December 8, 2023 10:47
@LSantha LSantha added verified bug Something isn't working labels Dec 8, 2023
@LSantha LSantha merged commit 56b8e37 into master Dec 8, 2023
18 checks passed
@LSantha LSantha deleted the issue-987-page-v3-issues branch December 8, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working verified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants