-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CIF-1938: show a resource status in the editor for product/category pages #849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #849 +/- ##
============================================
- Coverage 89.43% 89.42% -0.02%
- Complexity 1992 2001 +9
============================================
Files 331 332 +1
Lines 8854 8882 +28
Branches 1307 1313 +6
============================================
+ Hits 7919 7943 +24
- Misses 666 668 +2
- Partials 269 271 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
herzog31
approved these changes
Mar 23, 2022
laurentiumagureanu
approved these changes
May 10, 2022
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To make business users aware that changing a product / category page may impact many pages we introduce a ResourceStatusProvider that will cause a status bar to be shown when editing such a page.
The resource status contains an action to open the template page (when the current page is shown with product / category selected). This action is only available with the next Commerce AddOn version and will not be shown otherwise.
Related Issue
CIF-1938
Motivation and Context
Business user workflow improvements
How Has This Been Tested?
Unit tests, locally on AEM SDK
Screenshots (if appropriate):
Types of changes
Checklist: