Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIF-1938: show a resource status in the editor for product/category pages #849

Merged
merged 13 commits into from
Jun 2, 2022

Conversation

Buuhuu
Copy link
Contributor

@Buuhuu Buuhuu commented Mar 3, 2022

Description

To make business users aware that changing a product / category page may impact many pages we introduce a ResourceStatusProvider that will cause a status bar to be shown when editing such a page.

The resource status contains an action to open the template page (when the current page is shown with product / category selected). This action is only available with the next Commerce AddOn version and will not be shown otherwise.

Related Issue

CIF-1938

Motivation and Context

Business user workflow improvements

How Has This Been Tested?

Unit tests, locally on AEM SDK

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

@codecov
Copy link

codecov bot commented Mar 3, 2022

Codecov Report

Merging #849 (9ed1bb0) into master (ea326ac) will decrease coverage by 0.01%.
The diff coverage is 85.71%.

@@             Coverage Diff              @@
##             master     #849      +/-   ##
============================================
- Coverage     89.43%   89.42%   -0.02%     
- Complexity     1992     2001       +9     
============================================
  Files           331      332       +1     
  Lines          8854     8882      +28     
  Branches       1307     1313       +6     
============================================
+ Hits           7919     7943      +24     
- Misses          666      668       +2     
- Partials        269      271       +2     
Flag Coverage Δ
integration 52.71% <10.71%> (-0.23%) ⬇️
jest 86.38% <ø> (ø)
karma 95.26% <ø> (ø)
unittests 88.74% <85.71%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...al/services/CatalogPageResourceStatusProvider.java 85.71% <85.71%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea326ac...9ed1bb0. Read the comment docs.

@Buuhuu Buuhuu merged commit fed392b into master Jun 2, 2022
@Buuhuu Buuhuu deleted the issue/CIF-1938 branch June 2, 2022 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants