Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIF-2526 - Add add-to-cart button in all product collections #853

Merged
merged 3 commits into from
Mar 11, 2022

Conversation

LSantha
Copy link
Collaborator

@LSantha LSantha commented Mar 9, 2022

  • implemented 'Add to Cart' and 'Add to Wish List' button for the components: productcollection, productlist, searchresults, productcarousel, relatedproducts
  • updated UI tests, uint tests and intergation tests
  • updated exmamples library pages
  • updated the readme of related components

Related Issue

CIF-2526

How Has This Been Tested?

unit tests, UI tets, integration tests, manual testing

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

 * implemented 'Add to Cart' and 'Add to Wish List' button for the components: productcollection, productlist, searchresults, productcarousel, relatedproducts
 * updated UI tests, uint tests and intergation tests
 * updated exmamples library pages
 * updated the readme of related components
@LSantha LSantha added enhancement New feature or request feature New feature or request labels Mar 9, 2022
@codecov
Copy link

codecov bot commented Mar 9, 2022

Codecov Report

Merging #853 (7929636) into master (e59ff54) will increase coverage by 0.15%.
The diff coverage is 83.95%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #853      +/-   ##
============================================
+ Coverage     69.47%   69.62%   +0.15%     
- Complexity     1150     1160      +10     
============================================
  Files           316      320       +4     
  Lines          8396     8475      +79     
  Branches       1265     1269       +4     
============================================
+ Hits           5833     5901      +68     
- Misses         2153     2159       +6     
- Partials        410      415       +5     
Flag Coverage Δ
integration 55.25% <56.00%> (+0.02%) ⬆️
jest 86.40% <ø> (ø)
karma 95.44% <96.42%> (+0.06%) ⬆️
unittests 90.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...erce/core/components/internal/models/v1/Utils.java 47.82% <0.00%> (-2.18%) ⬇️
...models/v1/productcarousel/ProductCarouselImpl.java 64.89% <ø> (ø)
...nal/models/v1/productteaser/ProductTeaserImpl.java 44.15% <0.00%> (+0.56%) ⬆️
...models/v1/relatedproducts/RelatedProductsImpl.java 55.76% <ø> (ø)
...core/components/models/common/ProductListItem.java 0.00% <0.00%> (ø)
...onents/models/productcarousel/ProductCarousel.java 0.00% <0.00%> (ø)
...ts/models/productcollection/ProductCollection.java 0.00% <0.00%> (ø)
...ls/v1/productcollection/ProductCollectionImpl.java 53.84% <71.42%> (+3.84%) ⬆️
...models/v1/productcarousel/ProductCarouselBase.java 91.30% <80.00%> (-8.70%) ⬇️
...rousel/v1/productcarousel/clientlibs/js/actions.js 96.42% <96.42%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e59ff54...7929636. Read the comment docs.

@laurentiumagureanu laurentiumagureanu merged commit a307176 into master Mar 11, 2022
@laurentiumagureanu laurentiumagureanu deleted the CIF-2526 branch March 11, 2022 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants