Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIF-2826: Support for Peregrine ~12.5.0 #941

Merged
merged 7 commits into from
Jul 14, 2022
Merged

Conversation

buuhuu
Copy link
Contributor

@buuhuu buuhuu commented Jul 12, 2022

Description

This change extends the CIF react components to support peregrine ~12.5.0:

  • allow peregrine 12.5.0 as peer dependency
  • add uids to the products queries to conform with the expected schema of peregrine 12.5.
  • add some exports currently used by the CommerceApp as with peregrine 12.5.0 this component cannot be used anymore (it defines mainly the apollo client and a stack of deprecated contexts)

Related Issue

CIF-2826

Motivation and Context

To support the full features of the experience platform connector we want to make use of the new eventing stack introduced with peregrine 12.5.0.

How Has This Been Tested?

Locally with wknd-commerce

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

@buuhuu buuhuu added the enhancement New feature or request label Jul 12, 2022
@codecov
Copy link

codecov bot commented Jul 13, 2022

Codecov Report

Merging #941 (b297f8d) into master (d6ed0ba) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #941   +/-   ##
=========================================
  Coverage     89.71%   89.71%           
  Complexity     2154     2154           
=========================================
  Files           347      347           
  Lines          9673     9673           
  Branches       1394     1394           
=========================================
  Hits           8678     8678           
  Misses          713      713           
  Partials        282      282           
Flag Coverage Δ
integration 52.28% <ø> (ø)
jest 86.55% <ø> (ø)
karma 95.33% <ø> (ø)
unittests 88.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6ed0ba...b297f8d. Read the comment docs.

@laurentiumagureanu laurentiumagureanu merged commit daa88fa into master Jul 14, 2022
@laurentiumagureanu laurentiumagureanu deleted the issue/CIF-2826 branch July 14, 2022 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants