Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preheader not showing up on the delivered Email #250

Closed
priyankpardiwala opened this issue Dec 9, 2022 · 5 comments · Fixed by #258
Closed

Preheader not showing up on the delivered Email #250

priyankpardiwala opened this issue Dec 9, 2022 · 5 comments · Fixed by #258
Labels
bug Something isn't working to verify

Comments

@priyankpardiwala
Copy link

Hello - it looks like the email core page component does not insert preheader text from page properties into the Body of the HTML.

As a result - the delivered emails do not show the preheader text entered in Page Properties.
@bpauli bpauli added the bug Something isn't working label Dec 14, 2022
@bpauli
Copy link
Contributor

bpauli commented Dec 14, 2022

@adobe export issue to Jira project SITES as Bug

@github-jira-sync-bot
Copy link
Collaborator

✅ Jira issue SITES-10299 is successfully created for this GitHub issue.

@bpauli
Copy link
Contributor

bpauli commented Dec 14, 2022

Hi @priyankpardiwala, Thank you for bringing this up!

Can you please provide an example of the expected behaviour of the preheader ? Should this text be used for the preview of an email or just as 1st element before a component can be inserted into the body? The definition of preheader is sometimes mixed with the preview text (see also https://www.litmus.com/blog/the-ultimate-guide-to-preview-text-support) Thanks!

@priyankpardiwala
Copy link
Author

Hi @bpauli -

Preheader would be the first element in the tag. But it should have a display:none on the style attribute.

That way even though the preheader text is not directly visible on the page, it shows up as preview of the email below the "Subject" line on the email clients.

Here's a sample markup:

<body>
	<div style="display:none;font-size:1px;color:#fefefe;line-height:1px;max-height:0px;max-width:0px;opacity:0;overflow:hidden;">
	  ${pageProperties.preHeadertext @context='html'}      
	</div>
        <!--rest of the page markup -->
</body>

bpauli added a commit that referenced this issue Feb 6, 2023
@bpauli
Fix missing usage of the preheader page property
43448c6 
- add sling model for email page and add getPreHeader method
- add div for pre header in page template
- add unit and selenium tests

fixes #250
@bpauli bpauli mentioned this issue Feb 6, 2023
Merged
@bpauli
Copy link
Contributor

bpauli commented Feb 10, 2023

@priyankpardiwala, Can you please validate if the issue is fixed with the latest release (1.2.0) Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working to verify
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix missing usage of the preheader page property adobe/aem-core-email-components
3 participants
@bpauli @github-jira-sync-bot @priyankpardiwala