Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev to master 1 feb 24 #1058

Merged
merged 10 commits into from
Feb 2, 2024
Merged

Dev to master 1 feb 24 #1058

merged 10 commits into from
Feb 2, 2024

Conversation

barshat7
Copy link
Contributor

@barshat7 barshat7 commented Feb 1, 2024

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

dmaurya929 and others added 10 commits February 1, 2024 05:47
* Hide layout field for tabs/wizard/accordion in edit dialog

* Hide layout field for tabs/wizard/accordion in edit dialog

* Remove duplication

---------

Co-authored-by: demaurya <demaurya@adobe.com>
* file input highlight drop area initial

* file input highlight drop area

---------

Co-authored-by: Rajat Khurana <rajatkhurana@adobe.com>
…t object to custom functions as last argument (#1054)

Co-authored-by: Arun Kumar Attri <aattri@adobe.com>
Co-authored-by: Gulshan Mishra <gulshanm@adobe.com>
* FORMS-12557 Forms run enhancements

* adding qualified name in data layer to support repeatibility

* Fixing test

* Adding validation type and fixing submit start

* Adding rum JS library
@adobe-bot
Copy link

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 86 100 100 73

@adobe-bot
Copy link

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 100 100 73

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (127f0ee) 80.40% compared to head (29df65c) 80.40%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1058   +/-   ##
=========================================
  Coverage     80.40%   80.40%           
  Complexity      738      738           
=========================================
  Files            91       91           
  Lines          2057     2057           
  Branches        273      273           
=========================================
  Hits           1654     1654           
  Misses          251      251           
  Partials        152      152           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rismehta rismehta merged commit f72b5d5 into master Feb 2, 2024
9 checks passed
@rismehta rismehta deleted the dev-to-master-1-feb-24 branch February 2, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants