Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev to master 14 feb #1075

Merged
merged 23 commits into from
Feb 15, 2024
Merged

Dev to master 14 feb #1075

merged 23 commits into from
Feb 15, 2024

Conversation

girotraapankaj
Copy link
Collaborator

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

barshat7 and others added 22 commits December 15, 2023 08:37
* Hide layout field for tabs/wizard/accordion in edit dialog

* Hide layout field for tabs/wizard/accordion in edit dialog

* Remove duplication

---------

Co-authored-by: demaurya <demaurya@adobe.com>
* file input highlight drop area initial

* file input highlight drop area

---------

Co-authored-by: Rajat Khurana <rajatkhurana@adobe.com>
…t object to custom functions as last argument (#1054)

Co-authored-by: Arun Kumar Attri <aattri@adobe.com>
Co-authored-by: Gulshan Mishra <gulshanm@adobe.com>
FORMS-12807 | ReCaptcha fix for form embed in sites
FORMS-12679: Strings is unlocalized in "Search and Lister" Component in "Preview" mode
* FORMS-12557 Forms run enhancements

* adding qualified name in data layer to support repeatibility

* Fixing test

* Adding validation type and fixing submit start

* Adding rum JS library
Co-authored-by: Navneet Agarwal <navneeta@adobe.com>
…ld be triggered once the correspond…

…ing constraints of field is changed.
FORMS-12157 update af web run time version for validate of field shou…
#1074)

* We are storing max file size as number while it is needed as string as per the specification.

- Appending the units in JSON explicitly

* test case for big file size

* formatting code
* Adding af-custom-function dependency

* Fixing package json

* Fixing package lock

* Updating package lock

* updating package lock

* Fixing custom functions

* Updating custom function
@adobe-bot
Copy link

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 84 100 100 73

@adobe-bot
Copy link

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 100 100 73

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate

@adobe-bot
Copy link

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 84 100 100 73

@adobe-bot
Copy link

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 100 100 73

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (8dad4ac) 80.40% compared to head (75972ad) 80.37%.

Files Patch % Lines
...ponents/internal/models/v1/form/FileInputImpl.java 66.66% 0 Missing and 1 partial ⚠️
...rms/core/components/models/form/FormContainer.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1075      +/-   ##
============================================
- Coverage     80.40%   80.37%   -0.03%     
- Complexity      738      739       +1     
============================================
  Files            91       91              
  Lines          2057     2059       +2     
  Branches        273      273              
============================================
+ Hits           1654     1655       +1     
  Misses          251      251              
- Partials        152      153       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@barshat7 barshat7 merged commit e6d9709 into master Feb 15, 2024
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet