Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devtomaster 18 apr #1197

Merged
merged 3 commits into from
Apr 18, 2024
Merged

Devtomaster 18 apr #1197

merged 3 commits into from
Apr 18, 2024

Conversation

barshat7
Copy link
Contributor

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

Pavitra Khatri and others added 3 commits April 18, 2024 09:05
* FORMS-12203: Added localization changes and test cases

* FORMS-12203: Updated test case

* FORMS-12203: Altered to contains instead of get

* FORMS-12203: Resolved comments

* FORMS-12203: Updated test cases

* FORMS-12203: Updated delete button

* FORMS-12203: Updated button

* Retry wizard.locale.spec.js tests

* FORMS-12203: Added theme request wait

* Update wizard.locale.spec.js

* Added latestaddon check

* Delete ui.tests/test-module/package-lock.json

* Update commands.js

* Revert "Delete ui.tests/test-module/package-lock.json"

This reverts commit fd97b53.

* Reverted package-lock.json changes

* FORMS-12203: Removed exception inline

* FORMS-12203: Resolved comments

* FORMS-12203: Update index.js

* FORMS-12203: Removed package-lock.json change

* Update index.js

* Update error message in index.js

* Update index.js

* Update wizard.locale.spec.js

* Removed an intercept

* Updated regex patterns

---------

Co-authored-by: Shivangi Mittal <shivangim@Shivangis-MacBook-Pro.local>
* FORMS-13851 Support for language in date picker and number input
@review @vdua
DOD(Yes)

* FORMS-13851 Support for language in date picker and number input
    @review @vdua
    DOD(Yes)

* FORMS-13851 Support for language in date picker and number input
        @review @vdua
        DOD(Yes)

* FORMS-13851 Support for language in date picker and number input
            @review @vdua
            DOD(Yes)

* FORMS-13851 Support for language in date picker and number input
                @review @vdua
                DOD(Yes)

* FORMS-13851 Support for language in date picker and number input
                    @review @vdua
                    DOD(Yes)

* FORMS-13851 Support for language in date picker and number input
                        @review @vdua
                        DOD(Yes)

* FORMS-13851 Support for language in date picker and number input
                            @review @vdua
                            DOD(Yes)

* Update space character for thousands separator in french lang

* FORMS-13851 Support for language in date picker and number input
                                @review @vdua
                                DOD(Yes)

---------

Co-authored-by: Varun Dua <vdua@adobe.com>
@adobe-bot
Copy link

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 100 100 73

@adobe-bot
Copy link

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 87 100 100 73

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

1 similar comment
@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

@adobe-bot
Copy link

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 92 100 100 73

@adobe-bot
Copy link

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 100 100 73

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

2 similar comments
@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

@adobe-bot
Copy link

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 94 100 100 73

@adobe-bot
Copy link

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 100 100 73

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

2 similar comments
@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 80.81%. Comparing base (ab496c7) to head (f0f6fae).

Files Patch % Lines
...obe/cq/forms/core/components/models/form/Base.java 0.00% 1 Missing ⚠️
...rms/core/components/models/form/FormContainer.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1197      +/-   ##
============================================
+ Coverage     80.75%   80.81%   +0.05%     
- Complexity      773      782       +9     
============================================
  Files            91       91              
  Lines          2110     2116       +6     
  Branches        285      286       +1     
============================================
+ Hits           1704     1710       +6     
  Misses          252      252              
  Partials        154      154              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rismehta rismehta merged commit ad0490c into master Apr 18, 2024
10 checks passed
@rismehta rismehta deleted the devtomaster-18Apr branch April 18, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants