Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Title] Add ID to support anchors #212

Closed
vladbailescu opened this issue Jun 12, 2018 · 4 comments
Closed

[Title] Add ID to support anchors #212

vladbailescu opened this issue Jun 12, 2018 · 4 comments
Labels
enhancement New feature, or improvement to an existing feature.
Milestone
2.9.0

Comments

@vladbailescu
Copy link
Member

It would be useful if titles would support anchors so you can link to a specific section of the page.
@vladbailescu vladbailescu added the enhancement New feature, or improvement to an existing feature. label Jun 12, 2018
@gabrielwalt
Copy link
Member

(CQ-4246477)

@gabrielwalt gabrielwalt added this to the Future milestone Jun 22, 2018
samyak1080 added a commit to samyak1080/aem-core-wcm-components that referenced this issue Jun 29, 2018
@samyak1080
Issue adobe#212 [Title] Add support for anchors.
411fb18
@samyak1080 samyak1080 mentioned this issue Jun 29, 2018
Closed
samyak1080 added a commit to samyak1080/aem-core-wcm-components that referenced this issue Jun 29, 2018
@samyak1080
Issue adobe#212 [Title] Add support for anchors.
0d79a22
@samyak1080 samyak1080 mentioned this issue Jun 29, 2018
Closed
@gabrielwalt
Copy link
Member

gabrielwalt commented Jul 4, 2018 •
edited
Loading

Many thanks for your great contribution, Samyak1080! Your pull request has sparked additional considerations that I tried to summarize in the below acceptance criteria. I think that with that, it will be a solid feature.

Acceptance Criteria

  • The IDs must be guaranteed to be unique, otherwise the page might be invalid HTML. To guarantee it to be unique, the hash of the component's path can be used.
  • Optionally, the author should be able to set an anchor name to be used for the ID instead of the automatically generated hash. Leaving that field empty will lead to the hash being generated automatically.

@gabrielwalt gabrielwalt modified the milestones: Future, 2.2.0 Jul 4, 2018
@gabrielwalt
Copy link
Member

An additional consideration that I got by diving into general requirements for analytics, is that we should actually add IDs to all components, this would make it easier to add tracking to them if desired. If this is the case, should we maybe move this logic to the product and make it part of the Style System?

Shivanshmathur added a commit to Shivanshmathur/aem-core-wcm-components that referenced this issue Jul 9, 2018
@Shivanshmathur
Issue adobe#212 [Title] Add support for anchors.
51a4059 
* User can manually enter an ID, spaces will automaticallly be removed.
* If ID field is empty, ID is generated as follows- 'Title Text without spaces' + '-hash of component's unique path'
* IDs are automatically updated if the component is moved to a new path.
@Shivanshmathur Shivanshmathur mentioned this issue Jul 9, 2018
Closed
Shivanshmathur added a commit to Shivanshmathur/aem-core-wcm-components that referenced this issue Jul 31, 2018
@Shivanshmathur
Issue adobe#212 [Title] Add support for anchors.
3b6a12b 
Added Hobbes test for the id
@richardhand richardhand modified the milestones: 2.2.0, Future Oct 12, 2018
@gabrielwalt gabrielwalt changed the title [Title] Add support for anchors [Title] Add ID to support anchors Jun 27, 2019
@richardhand
Copy link
Contributor

This issue will be fixed by #535, closing here as duplicate.

@richardhand richardhand modified the milestones: Future, 2.9.0 Feb 13, 2020
@vladbailescu vladbailescu modified the milestones: 2.9.0, 3.0.0 May 8, 2020
@vladbailescu vladbailescu modified the milestones: 3.0.0, 2.9.0 May 22, 2020
kwin added a commit to kwin/aem-core-wcm-components that referenced this issue Jun 14, 2022
@kwin
Remove embedded Sling Models Impl 1.4.12
1451605 
A newer version is already shipped with the minimally required AEM
version
This closes adobe#212
@kwin kwin mentioned this issue Jun 14, 2022
Merged
kwin added a commit to kwin/aem-core-wcm-components that referenced this issue Jun 14, 2022
@kwin
Remove embedded Sling Models Impl 1.4.12
7564b82 
A newer version is already shipped with the minimally required AEM
version
This closes adobe#212
vladbailescu pushed a commit that referenced this issue Jun 23, 2022
@kwin
Remove embedded Sling Models Impl 1.4.12 (#2218)
e6c27ea 
A newer version is already shipped with the minimally required AEM version

This closes #212
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature, or improvement to an existing feature.
Projects
None yet
Milestone
2.9.0
Development

No branches or pull requests
3 participants
@gabrielwalt @vladbailescu @richardhand