Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove embedded Sling Models Impl 1.4.12 #2218

Merged
merged 2 commits into from
Jun 23, 2022

Conversation

kwin
Copy link
Contributor

@kwin kwin commented Jun 14, 2022

A newer version is already shipped with the minimally required AEM
version
This closes #2212

Q                       A
Fixed Issues? Fixes #2212
Patch: Bug Fix? yes
Minor: New Feature? no
Major: Breaking Change? no
Tests Added + Pass? Yes
Documentation Provided Yes (code comments and or markdown)
Any Dependency Changes? no
License Apache License, Version 2.0

A newer version is already shipped with the minimally required AEM
version
This closes adobe#212
@kwin kwin force-pushed the feature/remove-sling-models-impl-embed branch from 1451605 to 7564b82 Compare June 14, 2022 17:24
@codecov
Copy link

codecov bot commented Jun 14, 2022

Codecov Report

Merging #2218 (59a63c0) into main (f49a734) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2218   +/-   ##
=========================================
  Coverage     86.84%   86.84%           
  Complexity     2433     2433           
=========================================
  Files           216      216           
  Lines          6523     6523           
  Branches       1003     1003           
=========================================
  Hits           5665     5665           
  Misses          342      342           
  Partials        516      516           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f49a734...59a63c0. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Jun 23, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
16.7% 16.7% Duplication

@vladbailescu vladbailescu merged commit e6c27ea into adobe:main Jun 23, 2022
@kwin
Copy link
Contributor Author

kwin commented Apr 28, 2023

@vladbailescu For some reason this never made it to the main branch (i.e. the most recent

<artifactId>org.apache.sling.models.impl</artifactId>
still has it). What happened to commit e6c27ea? It is not part of the main branch....

bpauli added a commit that referenced this pull request May 9, 2023
Revert accidental removal of #2219 and #2218

fixes #2212
@bpauli bpauli mentioned this pull request May 9, 2023
bpauli added a commit that referenced this pull request May 9, 2023
Revert accidental removal of #2219 and #2218

fixes #2212
bpauli added a commit that referenced this pull request May 9, 2023
Revert accidental removal of #2219 and #2218

fixes #2212
bpauli added a commit that referenced this pull request May 9, 2023
Revert accidental removal of #2219 and #2218

fixes #2212
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove embedded Sling Models Impl
2 participants