Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document javascript logic and necessary markup for the image component #33

Closed
kwin opened this issue Jun 19, 2017 · 0 comments
Closed

Document javascript logic and necessary markup for the image component #33

kwin opened this issue Jun 19, 2017 · 0 comments
Assignees
@raducotescu
Labels
documentation Documentation corrections or improvements.
Milestone
1.0.6

Comments

@kwin
Copy link
Contributor

kwin commented Jun 19, 2017

As the image component relies on some javascript to dynamically modify the DOM (to request the most appropriate image renditions) the necessary markup attributes for this javascript logic should be documented. This is especially important as otherwise extending from this component may easily lead to wrongly placed markup (compare with #30 (comment))
kwin added a commit to kwin/aem-core-wcm-components that referenced this issue Jun 19, 2017
@kwin
Document markup and javascript logic to request the most appropriate
faa3f83 
image rendition.

This fixes adobe#33
@kwin kwin mentioned this issue Jun 19, 2017
Closed
@raducotescu raducotescu self-assigned this Jun 27, 2017
@raducotescu raducotescu added documentation Documentation corrections or improvements. PR available labels Jun 27, 2017
@raducotescu raducotescu modified the milestone: 1.0.6 Aug 4, 2017
richardhand pushed a commit that referenced this issue Jan 28, 2020
@gaetanmarmasse
Merge pull request #33 from Bounteous-Inc/hotfix/amp/turn-off-amp-for…
e0f3ee1 
…-some-pages

Hotfix/amp/turn off amp for some pages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raducotescu raducotescu

Labels
documentation Documentation corrections or improvements.
Projects
None yet
Milestone
1.0.6
Development

Successfully merging a pull request may close this issue.

Document markup and javascript logic to request the most appropriate kwin/aem-core-wcm-components
2 participants
@raducotescu @kwin