Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OEmbedClientImpl leaks network connections #2715

Merged
merged 6 commits into from
Apr 8, 2024
Merged

OEmbedClientImpl leaks network connections #2715

merged 6 commits into from
Apr 8, 2024

Commits on Apr 5, 2024

  1. Use Closeable HTTP client in order to close the network connection af… 

    …ter use
    @andreeadracea
    andreeadracea committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    99eb30c View commit details
    Browse the repository at this point in the history

  2. Changes on the tests

    @andreeadracea
    andreeadracea committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    377a2ca View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2024

  1. Revert "Changes on the tests" 

    Change the implementation

This reverts commit 377a2ca.
    @andreeadracea
    andreeadracea committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    bf27db0 View commit details
    Browse the repository at this point in the history

  2. Revert "Use Closeable HTTP client in order to close the network conne… 

    …ction after use"

Change the implementation
This reverts commit 99eb30c.
    @andreeadracea
    andreeadracea committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    d1d5207 View commit details
    Browse the repository at this point in the history

  3. Using try-with-resources in order to close the HttpClient

    @andreeadracea
    andreeadracea committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    9885f5b View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into issue/SITES-14725

    @spopescu
    spopescu committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    f72ae72 View commit details
    Browse the repository at this point in the history