Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Library] Improve Content Fragment examples #556

Merged
merged 2 commits into from
Apr 25, 2019
Merged

Conversation

richardhand
Copy link
Contributor

@richardhand richardhand commented Apr 25, 2019

  • removes Core Component Content Fragment Model
  • adds Office Content Fragment Model
  • adds region tags
  • adds 3 x Adobe office CF samples
  • swaps CF, CF List examples for offices
  • stretches CF, CF List examples to full width
  • adds missing CF, CF List dialog field descriptions

Content Fragment
Screenshot 2019-04-25 at 14 23 13

Content Fragment List
Screenshot 2019-04-25 at 14 23 27

Q                       A
Fixed Issues? Fixes #554
Patch: Bug Fix?
Minor: New Feature? 👍
Major: Breaking Change?
Tests Added + Pass? N/A
Documentation Provided Yes (code comments and or markdown)
Any Dependency Changes?
License Apache License, Version 2.0

- removes Core Component Content Fragment Model
- adds Office Content Fragment Model
- adds region tags
- adds 3 x Adobe office CF samples
- swaps CF, CF List examples for offices
- stretches CF, CF List examples to full width
- adds missing CF, CF List dialog field descriptions
- corrects Office model scaffolding
@codecov-io
Copy link

Codecov Report

Merging #556 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             development     #556   +/-   ##
==============================================
  Coverage          83.18%   83.18%           
  Complexity           962      962           
==============================================
  Files                 96       96           
  Lines               3039     3039           
  Branches             552      552           
==============================================
  Hits                2528     2528           
  Misses               204      204           
  Partials             307      307

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 895d1ee...a454fcb. Read the comment docs.

@richardhand richardhand merged commit c2166c8 into development Apr 25, 2019
@richardhand richardhand deleted the issue/554 branch April 25, 2019 14:40
richardhand added a commit that referenced this pull request May 1, 2019
- removes Core Component Content Fragment Model
- adds Office Content Fragment Model
- adds region tags
- adds 3 x Adobe office CF samples
- swaps CF, CF List examples for offices
- stretches CF, CF List examples to full width
- adds missing CF, CF List dialog field descriptions

fixes #554
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants