Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/849 vulnerable third party #851

Merged
merged 5 commits into from
Dec 20, 2021
Merged

Conversation

bpauli
Copy link
Contributor

@bpauli bpauli commented Dec 16, 2021

This PR is a partial fix for the vulnerabilities issue reported in #849 . It fixes the issues for the ui.frontend.general and ui.tests module.

fix vulnerable issues for ui.tests module
fix vulnerabilities issue in ui.frontend.general module
@lgtm-com
Copy link

lgtm-com bot commented Dec 16, 2021

This pull request introduces 1 alert when merging 48eb523 into 875d082 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

Copy link

@bartoszglow bartoszglow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm audit on node 16.13.1 and npm 8.1.2 produces 7 moderate severity vulnerabilities.

src/main/archetype/ui.frontend.general/webpack.prod.js Outdated Show resolved Hide resolved
src/main/archetype/ui.frontend.general/webpack.prod.js Outdated Show resolved Hide resolved
src/main/archetype/pom.xml Outdated Show resolved Hide resolved
src/main/archetype/ui.frontend.general/webpack.common.js Outdated Show resolved Hide resolved
src/main/archetype/ui.frontend.general/package.json Outdated Show resolved Hide resolved
src/main/archetype/ui.frontend.general/webpack.dev.js Outdated Show resolved Hide resolved
src/main/archetype/ui.tests/test-module/lib/commons.js Outdated Show resolved Hide resolved
@bpauli bpauli merged commit 76c1990 into develop Dec 20, 2021
@bpauli bpauli deleted the issue/849-vulnerable-third-party branch December 20, 2021 10:10
blackbyte-pl pushed a commit to blackbyte-pl/aem-project-archetype that referenced this pull request Dec 22, 2021
    * fix vulnerabilities issues for ui.frontend.react module
    * fix vulnerabilities issues in ui.frontend.angular module
blackbyte-pl pushed a commit to blackbyte-pl/aem-project-archetype that referenced this pull request Dec 22, 2021
    * fix vulnerabilities issues for ui.frontend.react module
    * fix vulnerabilities issues in ui.frontend.angular module
bpauli pushed a commit that referenced this pull request Dec 22, 2021
* Issue/849 vulnerable third party (#851)
    * fix vulnerabilities issues for ui.frontend.react module
    * fix vulnerabilities issues in ui.frontend.angular module

* Issue/849 vulnerable third party (#851)
    * fix vulnerabilities issues for ui.frontend.react module
    * fix vulnerabilities issues in ui.frontend.angular module

Co-authored-by: Bartosz Borowski <pid63525@adobe.com>
blackbyte-pl pushed a commit to blackbyte-pl/aem-project-archetype that referenced this pull request Dec 22, 2021
    * fix vulnerabilities issues for ui.frontend.react module
    * fix vulnerabilities issues in ui.frontend.angular module
bpauli pushed a commit that referenced this pull request Dec 22, 2021
* Issue/849 vulnerable third party (#851)
    * fix vulnerabilities issues for ui.frontend.react module
    * fix vulnerabilities issues in ui.frontend.angular module

* Issue/849 vulnerable third party (#851)
    * fix vulnerabilities issues for ui.frontend.react module
    * fix vulnerabilities issues in ui.frontend.angular module

* Issue/849 vulnerable third party (#851)
    * fix vulnerabilities issues for ui.frontend.react module
    * fix vulnerabilities issues in ui.frontend.angular module

Co-authored-by: Bartosz Borowski <pid63525@adobe.com>
@bpauli bpauli added this to the 33 milestone Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants