CQ-4341233: Pass all sonar checks from CM pipeline

[Kronnox]

Description

Replaces an API call that is treated as deprecated by the AEM Sonar rules with an alternative implementation allowing the IT tests of the archetype to pass without any sonar warnings.

Motivation and Context

As discussed in IO-504, the closeQuietly method of the commons-io library was previously marked as deprecated. However, this decision was revised in version 2.9.0. The corresponding AEM Sonar rule, however, still flags it as deprecated.

How Has This Been Tested?

• Executing tests locally against a remote AEM instance
• Running the tests and sonar scans within a cloud manager pipeline

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[kwin]

Why workarounds for false positives? Just the Adobe Sonar rule needs to be fixed in this case IMHO

[Kronnox]

I would still suggest merging the workaround as a shortterm solution until a fix for the sonar rule is in place. As of now details on how the list of deprecations is generated remain unclear.

[vladbailescu]

Merging for now, to be re-visited when the Cloud Manager deprecation handling is fixed.