Skip to content

Commit

Permalink
Coverage fix for Xcode 12 (#63)
Browse files Browse the repository at this point in the history
* Coverage fix

* Reset cocoapods cache

* Enable coverage collection

* Update targets to ios 10

* Set a simulator that exists

* Remove overwritten settings, podfile update

* Conform to TestableExtension

* Revert simulator change

* Fixes after merge conflicts
  • Loading branch information
emdobrin committed Mar 14, 2022
1 parent 6fe0b88 commit bba49c0
Show file tree
Hide file tree
Showing 6 changed files with 15 additions and 15 deletions.
8 changes: 4 additions & 4 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,9 @@ jobs:
# restore pods related caches
- restore_cache:
keys:
- cocoapods-cache-v4-{{ arch }}-{{ .Branch }}-{{ checksum "Podfile.lock" }}
- cocoapods-cache-v4-{{ arch }}-{{ .Branch }}
- cocoapods-cache-v4
- cocoapods-cache-v5-{{ arch }}-{{ .Branch }}-{{ checksum "Podfile.lock" }}
- cocoapods-cache-v5-{{ arch }}-{{ .Branch }}
- cocoapods-cache-v5
- 1-gems-{{ checksum "Gemfile.lock" }}

# install Gemfile
Expand All @@ -40,7 +40,7 @@ jobs:
# save pods related files
- save_cache:
name: Saving CocoaPods Cache
key: cocoapods-cache-v4-{{ arch }}-{{ .Branch }}-{{ checksum "Podfile.lock" }}
key: cocoapods-cache-v5-{{ arch }}-{{ .Branch }}-{{ checksum "Podfile.lock" }}
paths:
- ./Pods
- ~/.cocoapods
Expand Down
8 changes: 2 additions & 6 deletions AEPAnalytics.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -1064,7 +1064,6 @@
isa = XCBuildConfiguration;
baseConfigurationReference = 7F67C440D2E79632BFEE85A7 /* Pods-AEPAnalyticsUnitTests.debug.xcconfig */;
buildSettings = {
ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES = YES;
CLANG_ENABLE_MODULES = YES;
CODE_SIGN_STYLE = Automatic;
DEVELOPMENT_TEAM = FKGEE875K4;
Expand All @@ -1081,15 +1080,13 @@
SWIFT_OPTIMIZATION_LEVEL = "-Onone";
SWIFT_VERSION = 5.0;
TARGETED_DEVICE_FAMILY = "1,2";
TVOS_DEPLOYMENT_TARGET = 10.0;
};
name = Debug;
};
2EBEE7892525A35400880E72 /* Release */ = {
isa = XCBuildConfiguration;
baseConfigurationReference = 4FB729EA9494DA855AD93AA6 /* Pods-AEPAnalyticsUnitTests.release.xcconfig */;
buildSettings = {
ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES = YES;
CLANG_ENABLE_MODULES = YES;
CODE_SIGN_STYLE = Automatic;
DEVELOPMENT_TEAM = FKGEE875K4;
Expand All @@ -1105,7 +1102,6 @@
PRODUCT_NAME = "$(TARGET_NAME)";
SWIFT_VERSION = 5.0;
TARGETED_DEVICE_FAMILY = "1,2";
TVOS_DEPLOYMENT_TARGET = 10.0;
};
name = Release;
};
Expand All @@ -1115,7 +1111,7 @@
buildSettings = {
CODE_SIGN_STYLE = Automatic;
INFOPLIST_FILE = AEPAnalytics/Tests/Info.plist;
IPHONEOS_DEPLOYMENT_TARGET = 14.1;
IPHONEOS_DEPLOYMENT_TARGET = 10.0;
LD_RUNPATH_SEARCH_PATHS = (
"$(inherited)",
"@executable_path/Frameworks",
Expand All @@ -1134,7 +1130,7 @@
buildSettings = {
CODE_SIGN_STYLE = Automatic;
INFOPLIST_FILE = AEPAnalytics/Tests/Info.plist;
IPHONEOS_DEPLOYMENT_TARGET = 14.1;
IPHONEOS_DEPLOYMENT_TARGET = 10.0;
LD_RUNPATH_SEARCH_PATHS = (
"$(inherited)",
"@executable_path/Frameworks",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,8 @@
buildConfiguration = "Debug"
selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
shouldUseLaunchSchemeArgsEnv = "YES">
shouldUseLaunchSchemeArgsEnv = "YES"
codeCoverageEnabled = "YES">
<Testables>
<TestableReference
skipped = "NO">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import Foundation


class TestableExtensionRuntime: ExtensionRuntime {

var listeners: [String: EventListener] = [:]
var dispatchedEvents: [Event] = []
var createdSharedStates: [[String: Any]?] = []
Expand Down
4 changes: 2 additions & 2 deletions Podfile.lock
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
PODS:
- AEPAssurance (3.0.0):
- AEPAssurance (3.0.1):
- AEPCore (>= 3.1.0)
- AEPServices (>= 3.1.0)
- AEPCore (3.4.2):
Expand Down Expand Up @@ -33,7 +33,7 @@ SPEC REPOS:
- SwiftLint

SPEC CHECKSUMS:
AEPAssurance: 18068627111e366a851dc2166239f22b665101bd
AEPAssurance: b25880cd4b14f22c61a1dce19807bd0ca0fe9b17
AEPCore: b01856bf24972e4720cb0511a358d1e68067252a
AEPIdentity: fbf755560afcbb0acd66cd5b6a1c147530fca5f6
AEPLifecycle: 1e0e843465fb143f8d8949dcf06de169d5c26f62
Expand Down
6 changes: 4 additions & 2 deletions codecov.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,9 @@ coverage:
- "./AEPAnalytics/Mocks/**/*"
- "./AEPAnalytics/Tests/**/*"
- "./AEPAnalytics/Tests/.*"
- "./AnalyticsSampleApp/.*"
- "./AnalyticsSampleApp"
- "./Documentation"
- "./Script"
- "./build"

parsers:
Expand All @@ -36,4 +38,4 @@ parsers:
comment:
layout: "header, diff"
behavior: default
require_changes: no
require_changes: no

0 comments on commit bba49c0

Please sign in to comment.