Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverage fix for Xcode 12 #63

Merged
merged 9 commits into from
Mar 14, 2022
Merged

Coverage fix for Xcode 12 #63

merged 9 commits into from
Mar 14, 2022

Conversation

emdobrin
Copy link
Contributor

@emdobrin emdobrin commented Mar 12, 2022

Description

After updating CircleCI to run on Xcode 12, the functional tests failed to execute and the total code coverage report was only including the unit tests results, failing with:

warning: The iOS Simulator deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 14.1, but the range of supported deployment target versions is 9.0 to 14.0.99. (in target 'AEPAnalyticsFunctionalTests' from project 'AEPAnalytics')

Changed all the test targets to iOS 10.0

Related Issue

CocoaPods/CocoaPods#9884
CocoaPods/CocoaPods#9936

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Mar 12, 2022

Codecov Report

Merging #63 (7060c5b) into dev-v3.0.4 (1a14741) will increase coverage by 34.24%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           dev-v3.0.4      #63       +/-   ##
===============================================
+ Coverage       55.92%   90.15%   +34.24%     
===============================================
  Files              14       14               
  Lines            1107     1107               
===============================================
+ Hits              619      998      +379     
+ Misses            488      109      -379     

@emdobrin emdobrin changed the title Coverage fix Coverage fix for Xcode 12 Mar 12, 2022
@emdobrin emdobrin marked this pull request as ready for review March 14, 2022 16:27
@kevinlind kevinlind merged commit bba49c0 into adobe:dev-v3.0.4 Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants