Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge to Staging for 5.0.1 release #460

Merged
merged 7 commits into from
Apr 27, 2024
Merged

Merge to Staging for 5.0.1 release #460

merged 7 commits into from
Apr 27, 2024

Conversation

kevinlind
Copy link
Collaborator

Description

Merge to staging for 5.0.1 release

  • Updates workflow to bundle Edge configuration with hit event at the time the event was recorded as opposed to when the hit is processed. Preserves logic to get Edge configuration when hits are processed to handle previously queued hits which were not set with the Edge configuration.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

emdobrin and others added 7 commits March 19, 2024 19:35
@emdobrin
Merge pull request #452 from adobe/staging
4817d95 
staging -> main for v5.0.0 release
@emdobrin
pod update (#454)
b20e80d
@timkimadobe
Fix integration test workflow - align with release script (#455)
d605a7a
@kevinlind
Merge pull request #457 from adobe/main
8ce116c 
sync main -> dev
@kevinlind
Cache configuration with Edge hit (resolves #367) (#458)
3c04830 
* Add configuration to EdgeDataEntity.

* Update processHit to retrieve configuration from EdgeDataEntity while preserving older workflow.

* Update EdgeHitProcessorTests to set configuration in EdgeDataEntity

* Add functional tests which validate queued entities are processed correctly.

* Change order of 'if' to place most common path first.

* Update log message when edge.configId is missing or empty.

* Factor out code to get Edge configuration to reduce func lines of code.

* Factor out common check on event.data

* Consolidate common code to create and queue data entity in functional tests.

* Refactor common getEdgeConfig logic

* Use JSON asserts for EdgeExtensionTests

* Update function comments for getDataQueue

* Remove getXDMSharedState closure from EdgeHitProcessor as it is not used.

* Add SharedStateReader for EdgeHitProcessor to retrieve state data

* Wait for consent value to be set before continuing testing

* Update function comment to correct 'returns' statement

* Suspend hit queue after updating Consent status to capture hits in EdgeExtensionTests
@kevinlind
Updating version to 5.0.1.
e54f434
@kevinlind
Merge pull request #459 from adobe/version-5.0.1-update
2fa903a 
Updating version to 5.0.1
@emdobrin emdobrin merged commit 699a4e2 into staging Apr 27, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emdobrin emdobrin emdobrin approved these changes

@timkimadobe timkimadobe timkimadobe approved these changes

@addb addb Awaiting requested review from addb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kevinlind @emdobrin @timkimadobe