fix: support boolean default (#30)

adobe · Nov 10, 2023 · f187e86 · f187e86
1 parent 8563ff5
commit f187e86
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 1 deletion.
diff --git a/schema/app.config.yaml.schema.json b/schema/app.config.yaml.schema.json
@@ -228,7 +228,7 @@
         "additionalProperties": false
       }
     },
-    "configSchemaValue": { "type": "string", "maxLength": 1000 },
+    "configSchemaValue": { "type": ["string", "boolean"], "maxLength": 1000 },
     "productDependencies": {
       "type": "array",
       "items": {

diff --git a/test/index.test.js b/test/index.test.js
@@ -580,6 +580,32 @@ application:
     }))
   })
 
+  test('default boolean = true', async () => {
+    global.fakeFileSystem.addJson(
+      {
+        '/package.json': '{}',
+        '/app.config.yaml': `
+        application:
+          runtimeManifest: { packages: {}}
+        configSchema:
+          properties:
+            - envKey: BYE
+              type: boolean
+              default: true
+`
+      }
+    )
+    await expect(appConfig.load({})).resolves.toEqual(expect.objectContaining({
+      configSchema: {
+        properties: [{
+          envKey: 'BYE',
+          type: 'boolean',
+          default: true
+        }]
+      }
+    }))
+  })
+
   test('valid no configSchema', async () => {
     global.fakeFileSystem.addJson(
       {