Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support boolean default #30

Merged
merged 1 commit into from Nov 10, 2023
Merged

fix: support boolean default #30

merged 1 commit into from Nov 10, 2023

Conversation

moritzraho
Copy link
Member

Description

Related Issue

https://jira.corp.adobe.com/browse/XCHG-9699

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #30 (1f3f77b) into master (fbe1305) will not change coverage.
Report is 2 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #30   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          255       255           
  Branches        76        76           
=========================================
  Hits           255       255           

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link
Contributor

@amulyakashyap09 amulyakashyap09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! and Try to check github warnings.

Copy link
Contributor

@arjuncooliitr arjuncooliitr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@moritzraho moritzraho merged commit f187e86 into master Nov 10, 2023
7 checks passed
@moritzraho moritzraho deleted the support-boolean-default branch November 10, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants