Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow no validation #32

Merged
merged 4 commits into from Dec 5, 2023
Merged

feat: allow no validation #32

merged 4 commits into from Dec 5, 2023

Conversation

moritzraho
Copy link
Member

@moritzraho moritzraho commented Nov 21, 2023

Description

see ACNA-2399

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0dc89bd) 100.00% compared to head (c47ca48) 100.00%.

❗ Current head c47ca48 differs from pull request most recent head 9711ed1. Consider uploading reports for the commit 9711ed1 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #32   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          255       260    +5     
  Branches        76        80    +4     
=========================================
+ Hits           255       260    +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/index.js Show resolved Hide resolved
@moritzraho moritzraho merged commit 754ff98 into master Dec 5, 2023
5 checks passed
@moritzraho moritzraho deleted the allow-no-validation branch December 5, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants