Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ACNA-2399 - update app config lib major #751

Merged
merged 9 commits into from
Jan 12, 2024
Merged

Conversation

moritzraho
Copy link
Member

@moritzraho moritzraho commented Nov 21, 2023

Description

depends on adobe/aio-cli-lib-app-config#32 + major release and update major here, DO NOT MERGE/RELEASE before as otherwise every command would trigger validation. this plugin major update will be part of the aio-cli@v10 release, in the next commit

NOTE: by default validateAppConfig is set to false when calling load on aio-cli-lib-app-config. We set it to true for pack.

relates to ACNA-2399

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@purplecabbage
Copy link
Member

I don't think these heroics are actually required as the next release will be a major and lock a node version that supports this:

  "dependencies": {
    "@adobe/aio-cli-lib-app-config": "^1.1.0",
    "@adobe/aio-cli-lib-app-config-next": "npm:@adobe/aio-cli-lib-app-config@^3.0.0",

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (75539c9) 100.00% compared to head (2a39ae3) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #751   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           56        56           
  Lines         3232      3236    +4     
  Branches       612       612           
=========================================
+ Hits          3232      3236    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@moritzraho moritzraho marked this pull request as ready for review December 1, 2023 09:35
@moritzraho moritzraho closed this Dec 1, 2023
@moritzraho moritzraho reopened this Dec 1, 2023
Copy link
Member

@shazron shazron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the commit, please put a note that validateAppConfig is by default false for everything, except for the pack command (which explicitly sets the option to true)

@moritzraho moritzraho changed the title feat: update app config lib major (2nd attempt) update app config lib major (2nd attempt) Dec 5, 2023
@shazron shazron changed the title update app config lib major (2nd attempt) fix: ACNA-2399 - update app config lib major Jan 12, 2024
@shazron shazron merged commit 1087e65 into master Jan 12, 2024
7 checks passed
@shazron shazron deleted the update-app-config-2 branch January 12, 2024 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants