-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ACNA-2399 - update app config lib major #751
Conversation
I don't think these heroics are actually required as the next release will be a major and lock a node version that supports this:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #751 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 56 56
Lines 3232 3236 +4
Branches 612 612
=========================================
+ Hits 3232 3236 +4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the commit, please put a note that validateAppConfig is by default false for everything, except for the pack command (which explicitly sets the option to true)
Description
depends on adobe/aio-cli-lib-app-config#32 + major release and update major here, DO NOT MERGE/RELEASE before as otherwise every command would trigger validation.this plugin major update will be part of the aio-cli@v10 release, in the next commitNOTE: by default
validateAppConfig
is set tofalse
when callingload
onaio-cli-lib-app-config
. We set it to true forpack
.relates to ACNA-2399
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: