Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add e2e test #106

Merged
merged 8 commits into from
Feb 14, 2020
Merged

add e2e test #106

merged 8 commits into from
Feb 14, 2020

Conversation

Yu1986
Copy link
Contributor

@Yu1986 Yu1986 commented Feb 5, 2020

Description

Create e2e test for aio-cli-plugin-runtime

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Feb 5, 2020

Codecov Report

Merging #106 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #106   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          57     57           
  Lines        1762   1762           
  Branches      312    312           
=====================================
  Hits         1762   1762
Impacted Files Coverage Δ
src/commands/runtime/action/create.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 021f328...f38b5ce. Read the comment docs.

Copy link
Member

@shazron shazron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e2e/e2e.js Outdated
stdout.print = true

test('aio-cli-plugin-runtime test', async () => {
const name = 'aio-cli-plugin-runtime'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

name not from package.json

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@Yu1986 Yu1986 requested a review from shazron February 14, 2020 07:41
@Yu1986 Yu1986 merged commit 9c9f9f4 into adobe:master Feb 14, 2020
@Yu1986 Yu1986 deleted the e2e branch February 14, 2020 07:44
bhageena pushed a commit to bhageena/aio-cli-plugin-runtime that referenced this pull request Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants