Incorrect implementation and test for function signatureUtils::fetchPemEncodedPublicKeys

[shazron]

Function signatureUtils::fetchPemEncodedPublicKeys :

aio-lib-events/src/signatureUtils.js

Lines 50 to 68 in bfb5e17

	/**
	* Feteched the pem encoded public keys either from the state lib cache or directly via cloud front url
	*
	* @param {*} pubKeyUrl1 cloud front url of format https://static.adobeioevents.com/prod/keys/pub-key-<random-uuid>.pem
	* @param {*} pubKeyUrl2 cloud front url of format https://static.adobeioevents.com/prod/keys/pub-key-<random-uuid>.pem
	* @returns {Array} of two public keys
	*/
	async function fetchPemEncodedPublicKeys (pubKeyUrl1, pubKeyUrl2) {
	let pubKey1Pem, pubKey2Pem
	try {
	const state = await stateLib.init()
	pubKey1Pem = await fetchPubKeyFromCacheOrApi(pubKeyUrl1, state)
	pubKey2Pem = await fetchPubKeyFromCacheOrApi(pubKeyUrl2, state)
	} catch (error) {
	logger.error('error occurred while fetching pem encoded public keys either from cache or public key urls due to %s', error.message)
	return helpers.exportFunctions.genErrorResponse(500, 'Error occurred while fetching pem encoded Public Key')
	}
	return [pubKey1Pem, pubKey2Pem]
	}

The problematic item is the catch() clause. It returns helpers.exportFunctions.genErrorResponse(500, 'Error occurred while fetching pem encoded Public Key'), which has a problem:

1. helpers.exportFunctions.genErrorResponse returns an object, and this function explicitly says it should return an Array of (two) strings (tuple).

This therefore renders the test "Test Fetch Pem Encoded Public Keys -> verify for invalid pub key url throws" in signatureUtils.test.js as an invalid test since it will never throw an error. In fact the test is bogus - it doesn't really test the (mocked) return value - it tests an error that it sets up itself.

The test is here:

aio-lib-events/test/signatureUtils.test.js

Lines 91 to 108 in bfb5e17

	describe('Test Fetch Pem Encoded Public Keys', () => {
	it('verify for invalid pub key url throws', async () => {
	const invalidCloudFrontUrl = undefined
	fetch.mockImplementation(() => {
	return Promise.resolve(Error)
	})
	await signatureUtils.fetchPemEncodedPublicKeys(invalidCloudFrontUrl)
	.then(res => {
	throw new Error('invalid url')
	})
	.catch(e => {
	// eslint-disable-next-line jest/no-conditional-expect
	expect(e instanceof Error).toBe(true)
	// eslint-disable-next-line jest/no-conditional-expect
	expect(e.message).toEqual('invalid url')
	})
	})
	})

[aiojbot]

JIRA issue created: https://jira.corp.adobe.com/browse/ACNA-2498