Invalid test for function signatureUtils::getKeyFromCache

[shazron]

Function signatureUtils::getKeyFromCache :

aio-lib-events/src/signatureUtils.js

Lines 112 to 134 in bfb5e17

	/**
	* Gets the public key from cache
	*
	* @param {*} state aio state lib instance
	* @param {*} publicKeyFileNameAsKey public key file name in format pub-key-<random-uuid>.pem
	* @returns {string} public key
	*/
	async function getKeyFromCache (state, publicKeyFileNameAsKey) {
	try {
	const keyObj = await state.get(publicKeyFileNameAsKey)
	/**
	* key json obj fetched from cache in below format
	* {
	* "value":"pem public key",
	* "expiration":"24h timestamp"
	* }
	*/
	return keyObj.value
	} catch (error) {
	logger.error('aio lib state get error due to => %s', error.message)
	}
	return null
	}

On error, the function returns null, and never rethrows an Error.

The test "Test Get Key from Cache -> get key from cache throws" in signatureUtils.test.js is an invalid test since the tested function will never throw an error. In fact the test is bogus - it doesn't really test the return value or catch the function's error - it tests an error that it sets up itself.

The test is here:

aio-lib-events/test/signatureUtils.test.js

Lines 109 to 121 in bfb5e17

	describe('Test Get Key from Cache', () => {
	it('get key from cache throws', async () => {
	await signatureUtils.getKeyFromCache('state', 'invalid-url')
	.then(res => {
	throw new Error('lib state get error')
	})
	.catch(e => {
	// eslint-disable-next-line jest/no-conditional-expect
	expect(e instanceof Error).toBe(true)
	// eslint-disable-next-line jest/no-conditional-expect
	expect(e.message).toEqual('lib state get error')
	})
	})

[aiojbot]

JIRA issue created: https://jira.corp.adobe.com/browse/ACNA-2499