Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for custom CDN host option #55

Closed
moritzraho opened this issue Aug 18, 2020 · 4 comments
Closed

Support for custom CDN host option #55

moritzraho opened this issue Aug 18, 2020 · 4 comments
Labels
bug Something isn't working

Comments

@moritzraho
Copy link
Member

moritzraho commented Aug 18, 2020

Actual behavior

The CDN domain is fixed (see https://github.com/adobe/aio-lib-files/blob/master/lib/impl/AzureBlobFiles.js#L29) and points to the Adobe I/O Firefly CDN, this is a problem if the user is bringing his own storage via Files.init({ azure: <storage creds> }) as URLs would be broken.

Expected behavior

Support for a custom CDN host option on files init, e.g. Files.init({ host: 'mycdn.domain' })
EDIT: Let the TVM return the hostname as part of the credentials, as the logic handling this is already added by #66

Why

  • allows support for bring you own storage => DONE in BYO creds related issue #66
  • allow to test the files lib against non-prod environments
@moritzraho
Copy link
Member Author

relates to #52

@moritzraho moritzraho added the bug Something isn't working label Aug 18, 2020
@aiojbot
Copy link
Collaborator

aiojbot commented Aug 18, 2020

JIRA issue created: https://jira.corp.adobe.com/browse/ACNA-898

@moritzraho
Copy link
Member Author

moritzraho commented Feb 26, 2021

Reopening because #66 did not solve the case of using non-prod TVMs, the TVM should return the CDN host name. Which would fix this transparently

@moritzraho moritzraho reopened this Feb 26, 2021
@moritzraho
Copy link
Member Author

Closing this stale issue as #90 brought support for our stage TVM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants